Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Vega-Lite 5.17.0 #3367

Merged
merged 6 commits into from
Mar 17, 2024
Merged

Upgrade to Vega-Lite 5.17.0 #3367

merged 6 commits into from
Mar 17, 2024

Conversation

binste
Copy link
Contributor

@binste binste commented Mar 16, 2024

No description provided.

@binste binste marked this pull request as draft March 16, 2024 14:03
@binste binste marked this pull request as ready for review March 16, 2024 14:59
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @binste ! Maybe let's have one more approval since it is for the release?

Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I skimmed through all of the generated code and it looks reasonable. And given that the tests I'm happy for this to merge.

@binste binste merged commit 0ea4976 into vega:main Mar 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants