Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type checker errors for libraries such as Polars where Altair uses dataframe interchange protocol #3297

Merged
merged 10 commits into from
Dec 25, 2023
Merged

Fix type checker errors for libraries such as Polars where Altair uses dataframe interchange protocol #3297

merged 10 commits into from
Dec 25, 2023

Commits on Dec 23, 2023

  1. Switch interchange abc classes to protocols

    @binste
    binste committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    485d03f View commit details
    Browse the repository at this point in the history

  2. Remove interchange types which are not used. For Column, only keep th… 

    …e parts of the Protocol which we need for our codebase to make the type hint more flexible
    @binste
    binste committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    83f6ec0 View commit details
    Browse the repository at this point in the history

  3. Remove unused methods and properties of DataFrame Protocol, i.e. only… 

    … keep the ones which are relevant for our codebase. get_chunks is not directly used in Altair codebase but is relevant for pi.from_dataframe
    @binste
    binste committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    b6927f3 View commit details
    Browse the repository at this point in the history

  4. Relax type hints to solve invariance issue with TypedDict and issue w… 

    …ith enums
    @binste
    binste committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    4e637c1 View commit details
    Browse the repository at this point in the history

  5. Adapt comment

    @binste
    binste committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    201ff76 View commit details
    Browse the repository at this point in the history

  6. Add type hint to 'version'

    @binste
    binste committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    4eab849 View commit details
    Browse the repository at this point in the history

  7. Specify explicit signature for __dataframe__. Remove DataFrame.versio… 

    …n as Pyright doesn't like that in Polars it is specified as a property which is semantically not the same as an attribute (the later can be set, properties are read-only by default)
    @binste
    binste committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    217939c View commit details
    Browse the repository at this point in the history

  8. Ruff

    @binste
    binste committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    6c84eb6 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2023

  1. Add note to changelog

    @binste
    binste committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    9fdd3b0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix_th_for_polars

    @binste
    binste committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    6dbad9e View commit details
    Browse the repository at this point in the history