Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken JupyterWidget chart by pinning Vega #3269

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

jonmmease
Copy link
Contributor

Closes #3268

Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonmmease!

Does this mean that we continuously need to bump Vega versions? Do you know of a good way to test when this is resolved so we can stop pinning it again? Could you add a note to NOTES_FOR_MAINTAINERS.md that this version should be kept up-to-date?

@mattijn
Copy link
Contributor

mattijn commented Nov 22, 2023

Was wondering the same. How does this interfere with:

alt.VEGAEMBED_VERSION, alt.VEGA_VERSION  # alt.VEGALITE_VERSION, 
('6', '5')

@jonmmease
Copy link
Contributor Author

I'll take another look at this when I update Vega-Lite. It might work to unpin the version and switch to the latest from https://esm.sh/.

…s expecting.

Add note to NOTES_FOR_MAINTAINERS.md to update the Vega-Lite version in JupyterChart.
@jonmmease
Copy link
Contributor Author

I updated the esm.sh URL to use the same vega embed, vega, and vega-lite versions as the rest of Altair. I added a note to NOTES_FOR_MAINTAINERS with instructions for updating this URL when we update vega-lite.

@jonmmease jonmmease merged commit 1e17571 into main Nov 23, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vega 5.26.1 breaks JupyterChart
3 participants