Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Vega-Lite 5.15.1 #3206

Merged
merged 13 commits into from
Oct 3, 2023
Merged

Update to Vega-Lite 5.15.1 #3206

merged 13 commits into from
Oct 3, 2023

Conversation

joelostblom
Copy link
Contributor

@mattijn @binste @jonmmease @ChristopherDavisUCI Would you be OK if we make a 5.1.2 (this seems to small for 5.2?) early next week to update VL once vega/vega-lite#9106 is merged and to include #3191? It would be helpful for a class I'm teaching mid-next week. I can try to make the release since I'm the one who needs it, but if anyone has time to help if needed it is of course appreciated (the release instructions seem straightforward so hopefully I don't set anything on fire).

I put up this PR as a draft to make sure I am doing the correct thing when updating VL; I will flag for review when there is an actual VL 5.16 release. I bumped the version number in tools/generate_schema_wrapper.py and then ran python tools/generate_schema_wrapper.py, and then hatch test. Is that all?

CONTRIBUTING.md Outdated Show resolved Hide resolved
RELEASING.md Show resolved Hide resolved
Comment on lines +7057 to +7063
**See also:** The `projection with encodings and fields section
<https://vega.github.io/vega-lite/docs/selection.html#project>`__ in the
documentation.
fields : List(:class:`FieldName`)
An array of field names whose values must match for a data tuple to fall within the
selection.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in vega/vega-lite#9066 (comment), this is incorrect and will likely be removed in 5.16

@@ -15,6 +15,15 @@ Bug Fixes
Backward-Incompatible Changes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Version 5.1.2 (released Oct 4, 2023)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update this date depending on the actual release

@jonmmease
Copy link
Contributor

I'm supportive of doing a 5.1.2 release early next week. I haven't gone through the release process, but happy to make sure vl-convert is ready once Vega-Lite 5.16 is out.

Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me too, thanks for offering to do the release! Feel free to ping me again in case you need a review once the new VL version is out.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@@ -30,7 +30,7 @@

# Map of version name to github branch name.
SCHEMA_VERSION = {
"vega-lite": {"v5": "v5.14.1"},
"vega-lite": {"v5": "v5.15.0"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads-up that I'm simplifying this part of the code in #3207 and will merge it soon -> You will have a merge conflict here which should be simple to resolve. You can then just set SCHEMA_VERSION = "v5.15.0" as we no longer need the dictionary.

@mattijn
Copy link
Contributor

mattijn commented Sep 30, 2023

Go ahead! I'm a bit occupied these days. Ping me if you get stuck in the release proces.

@ChristopherDavisUCI
Copy link
Contributor

Hi all, I'm going to try to start being more involved with the day-to-day Altair maintenance than I have been in the last few months. Many things are still mysterious to me, but especially please ping me if there's something in particular you think I might be able to help with.

@joelostblom joelostblom changed the title Update to Vega-Lite 5.16 Update to Vega-Lite 5.15.1 Oct 2, 2023
@joelostblom
Copy link
Contributor Author

v5.15.1 was just released, when I tried updating this PR it fails to find a URL required the generate the schema. The URL is https://vega.github.io/schema/vega-lite/v5.15.1.json which indeed seems to be missing so maybe there is just a build process that takes some time for that to come up?

@binste
Copy link
Contributor

binste commented Oct 3, 2023

The publishing step to vega.github.io/schema failed, I opened an issue . However, the schema already exists on GitHub so you could point the Altair schema generation temporarily to that URL to get a head start until someone gets a chance to fix it :)

@jonmmease
Copy link
Contributor

vl-convert-python 0.14.0 was just published to PyPI with Vega-Lite 5.15.1 support

@joelostblom
Copy link
Contributor Author

All checks are passing so marking this as ready for review!

@joelostblom joelostblom marked this pull request as ready for review October 3, 2023 15:52
Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @joelostblom and @jonmmease

@joelostblom joelostblom merged commit 926c2c9 into main Oct 3, 2023
20 checks passed
@joelostblom
Copy link
Contributor Author

5.1.2 released! It was scary but I think everything is working. I didn't encounter any errors, and I tried installing 5.1.2 myself from pip and it seems to work as expected. Just waiting for https://github.com/conda-forge/altair-feedstock/pulls to update and then that should be it

@jonmmease
Copy link
Contributor

Thanks for doing the release @joelostblom!

@binste
Copy link
Contributor

binste commented Oct 3, 2023

Looks good, thanks! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants