Dynamically determine jsonschema validator #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which did not yet make format checker accessible on validator class
|
Thanks for this PR @binste! Could we add a test with two dummy schemas where one uses a draft 7 |
|
Sure! Is this what you had in mind? The test would fail in case the validation would no longer use a different validator class based on the $schema property. |
|
Yes! Looks good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2800
Tested with jsonschema 4.17.3 (newest) and 3.0.0 (minimum requirement). I had to introduce
$schemain the test schemas as well so that it takes the same validator for the tests as when validating against the latest vega-lite schema.