Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Lifting parameters to the top level #2684

Closed
wants to merge 14 commits into from
Closed

WIP: Lifting parameters to the top level #2684

wants to merge 14 commits into from

Commits on Sep 21, 2022

  1. Update vega to v5.22.1

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    626f04d View commit details
    Browse the repository at this point in the history

  2. Initial updates for lifting parameters 

    The main work has not been done yet: writing the function `_combine_subchart_params`.
    @ChristopherDavisUCI
    ChristopherDavisUCI committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    d6910db View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Write _combine_subchart_params function

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    7068283 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Update vega to v5.22.1 and vega-lite to v5.5.0

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    93892c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Preserve order of subcharts

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    0dfa66b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Distributing parameters added to Concat charts

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    c5fe43f View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Adding parameters to LayerChart, RepeatChart, FacetChart 

    Reverting back to the old definitions of `add_params`.  Also resetting `_counter` in a test.
    @ChristopherDavisUCI
    ChristopherDavisUCI committed Oct 2, 2022
    Configuration menu
    Copy the full SHA
    9079787 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2022

  1. Lifting params from the RepeatChart spec

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Oct 8, 2022
    Configuration menu
    Copy the full SHA
    b79460d View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2022

  1. Remove duplicate params from multiple layers

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    253838d View commit details
    Browse the repository at this point in the history

  2. Lifting params from FacetChart spec

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Oct 9, 2022
    Configuration menu
    Copy the full SHA
    33e3761 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Define interactive for concat charts 

    The interaction is bound between the charts (as opposed to another possibility, where the interaction would be added to each constituent chart separately).
    @ChristopherDavisUCI
    ChristopherDavisUCI committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    bc4a9b7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into liftparams

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    c8ed0e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. Merge remote-tracking branch 'upstream/master' into liftparams

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    3644282 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2022

  1. Naming repeat views

    @ChristopherDavisUCI
    ChristopherDavisUCI committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    f547323 View commit details
    Browse the repository at this point in the history