Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new advanced calculations section of the example gallery #2647

Merged
merged 10 commits into from
Jul 5, 2022

Conversation

palewire
Copy link
Contributor

@palewire palewire commented Jul 4, 2022

No description provided.

@joelostblom
Copy link
Contributor

I am leaning towards accepting the move of this and the violin plot PR #2648 , but I am not 100% certain since the current "Other" section is similar to Vega-Lite's "Advanced" section. I guess the question is whether we want to only classify charts by the type of mark they use, or how they are thought of conceptually (i.e. violins are not not just a type of area chart, but a distinct category on its own).

We currently have density charts under "Area charts" so with that logic it would make sense to move violins as well. If we move these two, I think we should also move the pyramid pie to the "circular plots" section, "Multiple marks" the Lineplots, Ridgeplot to Area, Wilkinson to Scatter, and Highlighted segment to Barplots.

What do you think @mattijn

@mattijn
Copy link
Contributor

mattijn commented Jul 4, 2022

Hm, good one. The VL counterpart is 'Advanced Calculations'. This calculations part is not something to ignore. If I look to the altair specifications of these parallel coordinate plots, I would say the pith of the matter is on the calculations part and not on the line part.
So I would suggest to introduce a section on advanced calculations or maybe even better, advanced transformations.
If this means the altair other section will be renamed or recategorized, that's OK.

@palewire
Copy link
Contributor Author

palewire commented Jul 5, 2022

I'm a fan of the greater specificity of your proposal. One of the things that inspired me to submit this PRs is that I find the "other" category a bit too vague. I will revise my proposal to fit the idea.

@palewire palewire changed the title Move parallel coordinates to line charts section Create a new advanced calculations section of the example gallery Jul 5, 2022
@palewire
Copy link
Contributor Author

palewire commented Jul 5, 2022

That's done. All of the other charts have been moved into a new Advanced Calculations section. IMHO, we could find better homes for a few of these. But I figured let's do this one step at a time.

Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changing, I think this looks good! One minor thing to get the CI to pass (I accepted this commit suggestion myself just to trigger the CI now).

altair/sphinxext/altairgallery.py Show resolved Hide resolved
@palewire
Copy link
Contributor Author

palewire commented Jul 5, 2022

I resolved conflicts from upstream merges and our tests are now passing.

@joelostblom joelostblom merged commit 029bc5a into vega:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants