-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a new advanced calculations section of the example gallery #2647
Conversation
I am leaning towards accepting the move of this and the violin plot PR #2648 , but I am not 100% certain since the current "Other" section is similar to Vega-Lite's "Advanced" section. I guess the question is whether we want to only classify charts by the type of mark they use, or how they are thought of conceptually (i.e. violins are not not just a type of area chart, but a distinct category on its own). We currently have density charts under "Area charts" so with that logic it would make sense to move violins as well. If we move these two, I think we should also move the pyramid pie to the "circular plots" section, "Multiple marks" the Lineplots, Ridgeplot to Area, Wilkinson to Scatter, and Highlighted segment to Barplots. What do you think @mattijn |
Hm, good one. The VL counterpart is 'Advanced Calculations'. This calculations part is not something to ignore. If I look to the altair specifications of these parallel coordinate plots, I would say the pith of the matter is on the calculations part and not on the line part. |
I'm a fan of the greater specificity of your proposal. One of the things that inspired me to submit this PRs is that I find the "other" category a bit too vague. I will revise my proposal to fit the idea. |
That's done. All of the other charts have been moved into a new Advanced Calculations section. IMHO, we could find better homes for a few of these. But I figured let's do this one step at a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing, I think this looks good! One minor thing to get the CI to pass (I accepted this commit suggestion myself just to trigger the CI now).
I resolved conflicts from upstream merges and our tests are now passing. |
No description provided.