Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new tables section #2646

Merged
merged 10 commits into from
Jul 5, 2022
Merged

Create a new tables section #2646

merged 10 commits into from
Jul 5, 2022

Conversation

palewire
Copy link
Contributor

@palewire palewire commented Jul 3, 2022

The other charts in the "Simple Charts" section at the top of the page have their own sections lower down. If that's our rule of thumb, we should add a heatmaps section too.

@joelostblom
Copy link
Contributor

What do you think about calling this section "Table-based" plots like in the Vega-Lite gallery https://vega.github.io/vega-lite/examples/#table-based-plots? Then you could also move over the GitHub punchcard and wind vector charts.

@palewire
Copy link
Contributor Author

palewire commented Jul 5, 2022

Sure. I've made the change as requested.

@palewire palewire changed the title Create a new heatmaps section Create a new tables section Jul 5, 2022
Copy link
Contributor

@joelostblom joelostblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joelostblom joelostblom merged commit 72bfb76 into vega:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants