Don't cast pandas.Categorical to object #2170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How come this PR was never merged? The pandas bug that's referenced in comment really does seem to have been fixed and recasting categories to object screws up e.g. ordering of axes. |
|
This was not merged because I was in the middle of an interstate move during a global pandemic and I ignored github for a while 😁 Can you confirm that this fixes any issue? JSON doesn't support categorical, so I don't think converting to string a different way will change how a chart orders items. Also, I'm not certain which pandas release has this fix, and it's useful to support older versions of dependencies unless breaking that support is absolutely necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the pandas bug mentioned in this comment is fixed so it may be possible to skip the conversion to object entirely
#245 (comment)