Skip to content

Commit

Permalink
ci: Update build.yml, pandas minimum version
Browse files Browse the repository at this point in the history
These should be the first supported versions our min python
  • Loading branch information
dangotbanned committed Oct 21, 2024
1 parent 61f1db7 commit da300c3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
jsonschema-version: ["3.0", "latest"]
name: py ${{ matrix.python-version }} js ${{ matrix.jsonschema-version }}
steps:
Expand All @@ -28,18 +28,18 @@ jobs:
- name: Maybe uninstall optional dependencies
# We uninstall pyarrow and vegafusion for one job to test that we have not
# accidentally introduced a hard dependency on these libraries.
# Uninstalling for Python 3.8 is an arbitrary choice.
# Uninstalling for Python 3.9 is an arbitrary choice.
# Also see https://github.com/vega/altair/pull/3114
if: ${{ matrix.python-version == '3.8' }}
if: ${{ matrix.python-version == '3.9' }}
run: |
pip uninstall -y pyarrow vegafusion vegafusion-python-embed vl-convert-python anywidget
- name: Maybe install lowest supported pandas version
# We install the lowest supported pandas version for one job to test that
# it still works. Downgrade to the oldest versions of pandas and numpy that include
# Python 3.8 wheels, so only run this job for Python 3.8
if: ${{ matrix.python-version == '3.8' }}
# Python 3.9 wheels, so only run this job for Python 3.9
if: ${{ matrix.python-version == '3.9' }}
run: |
pip install pandas==0.25.3 numpy==1.17.5
pip install pandas==1.1.3 numpy==1.19.3
- name: Test that schema generation has no effect
run: |
pip install vl-convert-python
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Source = "https://github.com/vega/altair"
all = [
"vega_datasets>=0.9.0",
"vl-convert-python>=1.7.0",
"pandas>=0.25.3",
"pandas>=1.1.3",
"numpy",
"pyarrow>=11",
"vegafusion[embed]>=1.6.6,<2",
Expand All @@ -69,7 +69,7 @@ dev = [
"ruff>=0.6.0",
"ibis-framework[polars]",
"ipython[kernel]",
"pandas>=0.25.3",
"pandas>=1.1.3",
"pytest",
"pytest-cov",
"pytest-xdist[psutil]~=3.5",
Expand Down

0 comments on commit da300c3

Please sign in to comment.