Update save.py to use utf-8 instead of None per default (#3278)

* Update save.py to use utf-8 instead of None per default I experience issues with the Null on windows. It appears as if when saving HTML, the template is already utf-8 and when writing the files with the system default code page, there are encoding issues. * incorporated tips from jonmmease - completely unchecked... trusting CI... * - formated... * - to trigger workflow.. * - to trigger workflow.. * Update altair/utils/save.py Co-authored-by: Jon Mease <[email protected]> * Update altair/utils/save.py Co-authored-by: Jon Mease <[email protected]> * fixed arg names.. * improved formating... * more formating... * more formating * Update api.py - fixed formating... wired... --------- Co-authored-by: franz haas <[email protected]> Co-authored-by: Jon Mease <[email protected]>
vega · Dec 6, 2023 · 6d1ded7 · 6d1ded7
1 parent e1bb266
commit 6d1ded7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/altair/utils/save.py b/altair/utils/save.py
@@ -142,7 +142,9 @@ def perform_save():
 
         if format == "json":
             json_spec = json.dumps(spec, **json_kwds)
-            write_file_or_filename(fp, json_spec, mode="w")
+            write_file_or_filename(
+                fp, json_spec, mode="w", encoding=kwargs.get("encoding", "utf-8")
+            )
         elif format == "html":
             if inline:
                 kwargs["template"] = "inline"
@@ -157,7 +159,12 @@ def perform_save():
                 json_kwds=json_kwds,
                 **kwargs,
             )
-            write_file_or_filename(fp, mimebundle["text/html"], mode="w")
+            write_file_or_filename(
+                fp,
+                mimebundle["text/html"],
+                mode="w",
+                encoding=kwargs.get("encoding", "utf-8"),
+            )
         elif format in ["png", "svg", "pdf", "vega"]:
             mimebundle = spec_to_mimebundle(
                 spec=spec,

diff --git a/altair/vegalite/v5/api.py b/altair/vegalite/v5/api.py
@@ -3247,7 +3247,7 @@ def add_selection(self, *selections) -> Self:
 
 
 def repeat(
-    repeater: Literal["row", "column", "repeat", "layer"] = "repeat"
+    repeater: Literal["row", "column", "repeat", "layer"] = "repeat",
 ) -> core.RepeatRef:
     """Tie a channel to the row or column within a repeated chart