Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to show cc and bcc recipients if present, and not error on missing To recipient #39

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

compwron
Copy link
Contributor

@compwron compwron commented Oct 2, 2024

Overview

Add ability to show bcc recipients if present, and not error on missing To recipient

Notes

This codebase uses https://www.npmjs.com/package/mailparser and the docs there imply to me that this is possible.

Command to run the tests on my local, thanks to denis90: NODE_OPTIONS="$NODE_OPTIONS --experimental-vm-modules" npm test

Refs: LM-zxy

test/app.test.js Outdated Show resolved Hide resolved
views/index.pug Outdated Show resolved Hide resolved
app.js Show resolved Hide resolved
@compwron compwron changed the title Add ability to show bcc recipients if present, and not error on missing To recipient Add ability to show cc and bcc recipients if present, and not error on missing To recipient Oct 2, 2024
@compwron compwron marked this pull request as ready for review October 2, 2024 14:56
@compwron
Copy link
Contributor Author

compwron commented Oct 2, 2024

@denis90 or @veelenga can you approve my PR GHA CI run and review/stamp? (Sorry to hurry you, I am just enthusiastic...) If you expect that it will take a few days or a week to get to this, I will just release a temporary npm fork build for my team :)

Copy link
Contributor

@denis90 denis90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@denis90 denis90 merged commit e8a7889 into veertech:main Oct 3, 2024
1 check passed
@compwron compwron deleted the allow-bcc branch October 3, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants