Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlib) Add new parse_bytes function #1198

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

titaneric
Copy link

@titaneric titaneric commented Dec 28, 2024

Summary

#49 discuss adding new function for parsing bytes, so I try to add this function here

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

cargo test
./scripts/check.sh

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

References

Close #49

If #1197 could be merged (also opened by me), I want to port the similar feature here to parse multiple bytes unit at once.

@titaneric titaneric marked this pull request as ready for review December 30, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VRL function to normalize size units like MiB, KiB, etc. to bytes
1 participant