enhancement(stdlib): Allow zip function to take two array parameters
#1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2-parameter micro benchmark shows that this two-parameter mode runs 50% faster than a single array of two arrays.
bruceg
added
type: enhancement
pront
approved these changes
Dec 2, 2024
src/stdlib/zip.rs
Outdated
Comment on lines
85
to
86
| array0: Box<dyn Expression>, | ||
| array1: Option<Box<dyn Expression>>, |
There was a problem hiding this comment.
nit:
Suggested change
| array0: Box<dyn Expression>, | |
| array1: Option<Box<dyn Expression>>, | |
| array_0: Box<dyn Expression>, | |
| array_1: Option<Box<dyn Expression>>, |
There was a problem hiding this comment.
If you say so. Fixed in 5935e89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2-parameter micro benchmark shows that this two-parameter mode runs 50% faster than a single array of two arrays.
Summary
Enhance the
zipfunction to take two forms:zip([[foo], [bar]])orzip([foo], [bar]). I plan to further enhance it to accept more parameters once this approach is ratified.Change Type
Is this a breaking change?
How did you test this PR?
Unit tests are included.
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References
Next part of #1157.