Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Add zip function #1158

Merged
merged 3 commits into from
Dec 2, 2024
Merged

feat(stdlib): Add zip function #1158

merged 3 commits into from
Dec 2, 2024

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Dec 2, 2024 •
edited by pront
Loading

Summary

Adds the zip function as described in #1157

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Unit tests are included in the sources

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on
    our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Our CONTRIBUTING.md is a good starting place.
  • If this PR introduces changes to LICENSE-3rdparty.csv, please
    run dd-rust-license-tool write and commit the changes. More details here.
  • For new VRL functions, please also create a sibling PR in Vector to document the new function.

@bruceg bruceg added vrl: stdlib Changes to the standard library type: feature A value-adding code addition that introduce new functionality. labels Dec 2, 2024
@bruceg bruceg requested a review from pront December 2, 2024 18:45
pront
pront reviewed Dec 2, 2024
View reviewed changes
src/stdlib/zip.rs Outdated
}

fn type_def(&self, _state: &TypeState) -> TypeDef {
TypeDef::object(Collection::any())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be array instead of object?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, yes. Fixed in d703cd5

@bruceg bruceg requested a review from pront December 2, 2024 19:33
pront
pront approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Will merge after we have the sibling PR in Vector to document the new function.

@bruceg
Copy link
Member Author

bruceg commented Dec 2, 2024

There are several other enhancements to this zip function planned. In discussion, we will submit the documentation PR to Vector separately once all the parts of this are completed.

@bruceg bruceg added this pull request to the merge queue Dec 2, 2024
Merged via the queue into main with commit 6c55b02 Dec 2, 2024
15 checks passed
@bruceg bruceg deleted the bruceg/zip-function branch December 2, 2024 20:27
@bruceg bruceg mentioned this pull request Dec 3, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphcareful graphcareful graphcareful approved these changes

@pront pront pront approved these changes

Assignees
No one assigned
Labels
type: feature A value-adding code addition that introduce new functionality. vrl: stdlib Changes to the standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bruceg @pront @graphcareful