feat(parse_cbor): add parse_cbor function #1152
Conversation
MiracleWisp
force-pushed
the
cbor_support
branch
6 times, most recently
from
8d6a19d to
1ca2e81
Compare
MiracleWisp
changed the title
MiracleWisp
force-pushed
the
cbor_support
branch
from
1ca2e81 to
554d4d0
Compare
src/stdlib/parse_cbor.rs
Outdated
| | Kind::object(Collection::any()) | ||
| } | ||
|
|
||
| fn type_def() -> TypeDef { |
There was a problem hiding this comment.
Is the intention for this and inner_kind() to be identical to JSON type defs?
There was a problem hiding this comment.
Yes, cbor uses the same data model as JSON (https://cbor.io/)
I will provide more tests to cover other types besides object and create a PR with documentation to the main vector repository
There was a problem hiding this comment.
Thank you for the explanation.
TIOLI: we can extract these type defs under a new directory src/stdlib/json_utils.
There was a problem hiding this comment.
Moved type defs to separate module and provided more examples for parse_cbor
MiracleWisp
force-pushed
the
cbor_support
branch
from
b1d7103 to
1ecef46
Compare
MiracleWisp
force-pushed
the
cbor_support
branch
3 times, most recently
from
dd269f4 to
4193d5f
Compare
MiracleWisp
force-pushed
the
cbor_support
branch
from
4193d5f to
38f70bb
Compare
| @@ -0,0 +1,2 @@ | |||
| [overrides] | |||
There was a problem hiding this comment.
I don't recall what does this do. Did you run dd-rust-license-tool?
There was a problem hiding this comment.
dd-rust-licence-tool fails without this config because "crunchy" package doesn't have repository config in cargo.toml
eira-fransham/crunchy#9
Summary
In this PR I would like to add support for cbor. We use this format as an alternative to JSON for more efficient data transfer to Kafka. And we would really like to be able to use vector in our projects
Change Type
Is this a breaking change?
How did you test this PR?
Unit tests are provided in this PR
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References