fix(kafka sink): retry messages that result in kafka policy violations #22041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
domain: sinks
PriceHiller
changed the title
PriceHiller
force-pushed
the
fix-kafka-sink-dropping-msgs
branch
from
3fb7bb2 to
3eaeee3
Compare
Problem: Some messages were getting dropped by Vector due to Kafka throwing `PolicyViolation` errors. These should be retried as a policy can be as simple as a more aggressive rate limit. ---------- Solution: Retry any messages that had the `RDKafkaErrorCode::PolicyViolation` error. ---------- Note: A dynamic back off may be better, as there may be a rate limit out there that still needs more than 100ms to back off on requests. ---------- See the original issue at vectordotdev#22026 Closes vectordotdev#22026
PriceHiller
force-pushed
the
fix-kafka-sink-dropping-msgs
branch
2 times, most recently
from
296551f to
3bfca14
Compare
|
Realized I did not need to include that changelog entry for this PR. |
jszwedko
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Actually could we add a changelog entry here describing the fix for users? See https://github.com/vectordotdev/vector/blob/master/changelog.d/README.md
PriceHiller
force-pushed
the
fix-kafka-sink-dropping-msgs
branch
from
3bfca14 to
296551f
Compare
Reincluded the changelog entry. |
jszwedko
reviewed
Dec 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Copied from the body of the commit:
Ensures Kafka retries messages that error out with
RDKafkaErrorCode::PolicyViolation.Change Type
Is this a breaking change?
How did you test this PR?
cargo test --no-default-features --features "sinks-console,sinks-kafka,kafka-integration-tests" -- --skip 'sinks::kafka::tests::integration_test' 'sinks::kafka'make test-integration-kafkaHas to do with
sources::kafka::integration_test::drains_acknowledgements_during_rebalance_default_assignmentsDoes this PR include user facing changes?
Checklist
Cargo.lock), pleaserun
dd-rust-license-tool writeto regenerate the license inventory and commit the changes (if any). More details here.References