Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(gcp_chronicle sink): add support for all Google SecOps regional endpoints #22033

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChocPanda
Copy link
Contributor

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Testing was limited as I don't have access to a chronicle instance outside of europe, however, the risk is minimal as this change just adds Google published endpoints to the available configuration options

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

https://cloud.google.com/chronicle/docs/reference/ingestion-api#regional_endpoints

…endpoints in the chronicle unstructured log sink
@ChocPanda ChocPanda requested a review from a team as a code owner December 13, 2024 22:13
@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Dec 13, 2024
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChocPanda

@pront pront changed the title enhancement(chronicle unstructured): add support for all Google SecOps regional endpoints enhancement(chronicle_unstructured sink): add support for all Google SecOps regional endpoints Dec 13, 2024
@pront
Copy link
Member

pront commented Dec 13, 2024

@ChocPanda ChocPanda changed the title enhancement(chronicle_unstructured sink): add support for all Google SecOps regional endpoints enhancement(gcp_chronicle sink): add support for all Google SecOps regional endpoints Dec 18, 2024
@ChocPanda
Copy link
Contributor Author

updated @pront , there's a GCP Chronicle semantic in there already.
Can you re-approve the pipeline run please

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ChocPanda !

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need to run cargo fmt when you get a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants