Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Fix baseline SHA default for new weekly schedule #21980

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

jszwedko
Copy link
Member

@jszwedko jszwedko commented Dec 7, 2024

Summary

#21979 updated the schedule to weekly, but it was still looking for the SHA from 24 hours ago meaning that most commits wouldn't be tested.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Will be tested by CI.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

Was still looking for the SHA from 24 hours ago.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 7, 2024
@jszwedko jszwedko requested review from a team as code owners December 7, 2024 00:32
@jszwedko jszwedko enabled auto-merge December 7, 2024 00:32
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/fix-default-baseline
Commit report: d059d9d
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

@jszwedko jszwedko added this pull request to the merge queue Dec 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 7, 2024
@pront pront added this pull request to the merge queue Dec 7, 2024
Merged via the queue into master with commit d4854de Dec 8, 2024
63 checks passed
@pront pront deleted the jszwedko/fix-default-baseline branch December 8, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants