Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(external): add notice for 'to_float' #21973

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

pront
Copy link
Member

@pront pront commented Dec 6, 2024

Summary

Add notice to explain the recent behavior change for to_float.

https://pront-to-float-notice-website.d1a7j77663uxsc.amplifyapp.com/docs/reference/vrl/functions/#to_float

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

#21970

@pront pront requested review from a team as code owners December 6, 2024 15:23
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 6, 2024
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

Copy link

github-actions bot commented Dec 6, 2024

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

Copy link

github-actions bot commented Dec 6, 2024

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

@pront pront enabled auto-merge December 6, 2024 15:36
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: pront/to-float-notice-website
Commit report: 7f16ff1
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.44s Total Time

@pront pront added this pull request to the merge queue Dec 6, 2024
Merged via the queue into master with commit 87c04eb Dec 6, 2024
56 checks passed
@pront pront deleted the pront/to-float-notice-website branch December 6, 2024 16:59
pront added a commit that referenced this pull request Dec 6, 2024
* docs(external): add notice for 'to_float'

* fix typo
jszwedko pushed a commit that referenced this pull request Dec 9, 2024
* docs(external): add notice for 'to_float'

* fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants