Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): multiple workflows need 'contents: write' permissions #21940

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

pront
Copy link
Member

@pront pront commented Dec 3, 2024

Summary

Fixes https://github.com/vectordotdev/vector/actions/runs/12143081309

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Dec 3, 2024
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Dec 3, 2024

Datadog Report

Branch report: pront/publish-perms
Commit report: c29b817
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.46s Total Time

@pront pront marked this pull request as ready for review December 3, 2024 18:37
@pront pront requested a review from a team as a code owner December 3, 2024 18:37
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you may need to update this in all of the workflows that call this one, too:

permissions:
contents: read
packages: write

permissions:
contents: read
packages: write

permissions:
contents: read
packages: write

@pront pront enabled auto-merge December 3, 2024 18:42
@pront pront changed the title fix(ci): publish workflow needs more permissions fix(ci): multiple workflows need 'contents: write' permissions Dec 3, 2024
@pront pront added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit aa48fea Dec 3, 2024
56 checks passed
@pront pront deleted the pront/publish-perms branch December 3, 2024 20:11
pront added a commit that referenced this pull request Dec 3, 2024
* pin to latest VRL

* cargo vdev build release-cue

* update versions

* fix static img link (need to automate this)

* add description

* vrl changelog added

* fix typo

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* spell checker fixes

* remove PartialOrd entry

* dd-rust-license-tool write

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* PR feedback and cue fmt

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* fix indentation

* fix indentation

---------

Co-authored-by: Sandra (neko) <[email protected]>
Co-authored-by: Jesse Szwedko <[email protected]>

fix(ci): multiple workflows need 'contents: write' permissions (#21940)

* fix(ci): publish workflow needs more permissions

* update more workflows
pront added a commit that referenced this pull request Dec 4, 2024
* pin to latest VRL

* cargo vdev build release-cue

* update versions

* fix static img link (need to automate this)

* add description

* vrl changelog added

* fix typo

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Sandra (neko) <[email protected]>

* spell checker fixes

* remove PartialOrd entry

* dd-rust-license-tool write

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* PR feedback and cue fmt

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* Update website/cue/reference/releases/0.43.0.cue

Co-authored-by: Jesse Szwedko <[email protected]>

* fix indentation

* fix indentation

---------

Co-authored-by: Sandra (neko) <[email protected]>
Co-authored-by: Jesse Szwedko <[email protected]>

fix(ci): multiple workflows need 'contents: write' permissions (#21940)

* fix(ci): publish workflow needs more permissions

* update more workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants