enhancement(elasticsearch sink): Add update support to bulk action #21860
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
domain: sinks
blackrez
changed the title
auto-merge was automatically disabled
November 21, 2024 17:22
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
November 22, 2024 06:53
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
November 22, 2024 15:34
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
November 22, 2024 15:53
Head branch was pushed to by a user without write access
auto-merge was automatically disabled
November 22, 2024 17:07
Head branch was pushed to by a user without write access
drichards-87
approved these changes
Nov 22, 2024
Co-authored-by: DeForest Richards <[email protected]>
Co-authored-by: DeForest Richards <[email protected]>
Co-authored-by: DeForest Richards <[email protected]>
|
@drichards-87 Thanks for the suggestions. |
auto-merge was automatically disabled
November 22, 2024 19:45
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Like discussed in #17852 I add the update support to the bulk API. We deployed it and it works like we wanted.
Change Type
Is this a breaking change?
How did you test this PR?
We use Elasticsearch with the following config files :
https://gist.github.com/blackrez/8b5ff94e081fe68c7811deb8c9e44079
Does this PR include user facing changes?
Checklist
References