Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): typo in permissions #21856

Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(ci): typo in permissions #21856

merged 1 commit into from
Nov 20, 2024
+2 −2

Conversation

pront
Copy link
Member

@pront pront commented Nov 20, 2024 •
edited
Loading

Summary

Per https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@pront pront requested a review from a team as a code owner November 20, 2024 22:50
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Nov 20, 2024
@pront pront merged commit f5bbdb9 into master Nov 20, 2024
37 of 38 checks passed
@pront pront deleted the pront/fix-typo branch November 20, 2024 22:50
jszwedko
jszwedko reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posthumous 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jszwedko jszwedko jszwedko left review comments

Assignees
No one assigned
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pront @jszwedko