Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump async-nats to v0.37 #21504

Closed
wants to merge 16 commits into from
Closed

chore(deps): bump async-nats to v0.37 #21504

wants to merge 16 commits into from

Conversation

paolobarbolini
Copy link
Contributor

@paolobarbolini paolobarbolini commented Oct 15, 2024 •
edited by pront
Loading

Supersedes: #20451
Closes #20008
Ref: aws/aws-lc-rs#661

@paolobarbolini paolobarbolini requested a review from a team as a code owner October 15, 2024 03:21
@paolobarbolini paolobarbolini mentioned this pull request Oct 15, 2024
Closed
pront
pront approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @paolobarbolini

@pront pront enabled auto-merge October 15, 2024 14:12
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 15, 2024
@pront pront added this pull request to the merge queue Oct 16, 2024
pront
pront reviewed Oct 16, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
@pront pront removed this pull request from the merge queue due to a manual request Oct 16, 2024
@paolobarbolini paolobarbolini requested a review from a team as a code owner October 16, 2024 23:15
@pront
Copy link
Member

pront commented Oct 24, 2024

There are Cargo.lock conflicts but otherwise this looks good 👍
I would recommended reverting all cargo lock changes and then cargo update -p async-nats.

@pront pront enabled auto-merge November 13, 2024 16:44
@pront pront disabled auto-merge November 13, 2024 16:58
@pront
Copy link
Member

pront commented Nov 13, 2024 •
edited
Loading

Hmm this doesn't build on MacOS. Will be fixed in the next release.

aws/aws-lc-rs#587

This was referenced Nov 13, 2024
Closed
Closed
@pront
Copy link
Member

pront commented Nov 18, 2024 •
edited
Loading

@pront pront mentioned this pull request Nov 20, 2024
Closed
@pront pront enabled auto-merge January 3, 2025 21:38
@pront pront added this pull request to the merge queue Jan 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 4, 2025
@pront pront enabled auto-merge January 16, 2025 20:14
@pront pront requested a review from jszwedko January 16, 2025 20:23
@github-actions github-actions bot added the domain: ci Anything related to Vector's CI environment label Jan 16, 2025
@pront pront disabled auto-merge January 16, 2025 20:24
@pront pront enabled auto-merge January 16, 2025 21:24
@pront pront removed the request for review from a team January 16, 2025 21:26
@pront pront added this pull request to the merge queue Jan 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 16, 2025
@pront pront added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@pront pront enabled auto-merge January 17, 2025 15:20
@pront pront added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@pront pront enabled auto-merge January 17, 2025 17:55
@pront pront added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@pront pront mentioned this pull request Jan 17, 2025
Merged
10 tasks
@pront
Copy link
Member

pront commented Jan 17, 2025

Closing in favor of #22238

The Go requirement was a curve ball: https://aws.github.io/aws-lc-rs/requirements/index.html

We want to enable fips everywhere eventually though, so we will revisit this.

@pront pront closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pront pront pront approved these changes

@jszwedko jszwedko jszwedko approved these changes

Assignees
No one assigned
Labels
domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolobarbolini @pront @jszwedko