-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(file source): Better multi-line support #1852
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
deb5b4c
Extracted LineAgg to a separate mod, mostly as is (except for visibil…
MOZGIII a4eaec4
Prepare the structure to implement new multiline logic
MOZGIII a3c510e
Implement handling lines with conditions
MOZGIII c55644e
Change tests for legacy mode to go through a different constructor
MOZGIII 689a6c2
Remove Mode::Legacy and reimplement it via new config
MOZGIII bb76980
Represent timeout as Duration
MOZGIII b574013
Switch to implementing legacy support at the Config level
MOZGIII 2b2c5d5
Tailor public interface visibility and derivations
MOZGIII 954c400
Add support for using new LineAgg interface at file source
MOZGIII 754ec83
Update CODEOWNERS
MOZGIII e716ecf
Update documentation
MOZGIII d3876f9
Add snafu display to regex parsing errors
MOZGIII 13cfa64
Use simpler try_into invocations
MOZGIII 1062684
Make LineAgg generic over line source identifiers (buffer keys)
MOZGIII 93a5a26
Use hash_map::Entry
MOZGIII 274eb9d
Add utility function to add next line to existing buffer
MOZGIII 4a01b5b
Move src/sources/file.rs to src/sources/file/mod.rs
MOZGIII 67a2c7f
Update CODEOWNERS
MOZGIII File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling issue. Should be "specified."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rcollette That spelling error has been addressed in later code. Thanks for letting us know though!