Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_info gauge metric behavior differs since 0.43 #21988

Closed
garethpelly opened this issue Dec 9, 2024 · 5 comments · Fixed by #21991
Closed

build_info gauge metric behavior differs since 0.43 #21988

garethpelly opened this issue Dec 9, 2024 · 5 comments · Fixed by #21991
Labels
meta: regression This issue represents a regression source: internal_metrics Anything `internal_metrics` source related type: bug A code related bug.

Comments

@garethpelly
Copy link
Contributor

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

Since 0.43, the build_info gauge metric is not emitting the last known value "1" indefinitely. As a result, it appears only once at start up and therefore this impacts the ability to monitor the counts of vector pods and their respective versions.

I noticed that the "metrics" dependency was updated from 0.24.0 to 0.24.1 in the 0.43 release but I can't spot what has changed to impact the behaviour.

Configuration

No response

Version

0.43

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

@garethpelly garethpelly added the type: bug A code related bug. label Dec 9, 2024
@pront pront added the source: internal_metrics Anything `internal_metrics` source related label Dec 9, 2024
@jszwedko
Copy link
Member

jszwedko commented Dec 9, 2024

Ah, this is likely the result of #20710 which change the default for the registry to expire entries (to avoid leaking). As a workaround, you can set https://vector.dev/docs/reference/configuration/global-options/#expire_metrics_secs to -1 to restore the previous default behavior of not expiring metrics.

The real fix is for this metric to be emitted on an interval so it doesn't expire.

@jszwedko
Copy link
Member

jszwedko commented Dec 9, 2024

I'm also noticing this didn't end up in the release changelog for some reason 🤔

jszwedko added a commit that referenced this issue Dec 9, 2024
For the new changelogs generated from changelog fragments, chores should be rendered too.

Addresses: #21988 (comment)

Signed-off-by: Jesse Szwedko <[email protected]>
jszwedko added a commit that referenced this issue Dec 9, 2024
For the new changelogs generated from changelog fragments, chores should be rendered too.

Addresses: #21988 (comment)

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko
Copy link
Member

jszwedko commented Dec 9, 2024

Oh I see, because it is a chore which are skipped when rendering. I opened #21990 to fix the rendering.

@pront
Copy link
Member

pront commented Dec 9, 2024

Oh I see, because it is a chore which are skipped when rendering. I opened #21990 to fix the rendering.

Interesting... good catch.

@jszwedko
Copy link
Member

jszwedko commented Dec 9, 2024

Fix: #21991

@jszwedko jszwedko added the meta: regression This issue represents a regression label Dec 9, 2024
@jszwedko jszwedko added this to the Vector v0.43.1 milestone Dec 9, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 9, 2024
For the new changelogs generated from changelog fragments, chores should be rendered too.

Addresses: #21988 (comment)

Signed-off-by: Jesse Szwedko <[email protected]>
jszwedko added a commit that referenced this issue Dec 9, 2024
For the new changelogs generated from changelog fragments, chores should be rendered too.

Addresses: #21988 (comment)

Signed-off-by: Jesse Szwedko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: regression This issue represents a regression source: internal_metrics Anything `internal_metrics` source related type: bug A code related bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants