Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit tag cardinality by metric in tag_cardinality_limit transform #15743

Open
jszwedko opened this issue Dec 27, 2022 · 5 comments · May be fixed by #22077
Open

Limit tag cardinality by metric in tag_cardinality_limit transform #15743

jszwedko opened this issue Dec 27, 2022 · 5 comments · May be fixed by #22077
Labels
transform: tag_cardinality_limit Anything `tag_cardinality_limit` transform related type: feature A value-adding code addition that introduce new functionality.

Comments

@jszwedko
Copy link
Member

A note for the community

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

The tag_cardinality_limit transform currently applies a global limit on tags. It'd be more useful to apply the limit per metric name.

Attempted Solutions

No response

Proposal

Apply the user-specified limits and behavior on a per-metric name basis.

References

Version

vector 0.26.0
@jszwedko jszwedko added transform: tag_cardinality_limit Anything `tag_cardinality_limit` transform related type: feature A value-adding code addition that introduce new functionality. labels Dec 27, 2022
@jszwedko jszwedko mentioned this issue Dec 27, 2022
Closed
@NasAmin
Copy link

NasAmin commented Mar 24, 2023

Any update on this?

@jszwedko
Copy link
Member Author

Nothing yet unfortunately.

@kaarolch
Copy link

@jszwedko any update about global rate limit per metric name?

@jszwedko
Copy link
Member Author

@jszwedko any update about global rate limit per metric name?

Nothing yet unfortunately. We are, of course, happy to entertain a pull request for this :)

@mbibaud
Copy link

mbibaud commented Dec 14, 2023

Note: the limit cardinality per metric-name should also consider the metric namespace. (or at least have this configurable)

It is a likely scenario that the same metric_name can be found in multiple namespace.
eg: foo.system.cpu.user and bar.system.cpu.user.

@nzxwang nzxwang mentioned this issue Oct 1, 2024
Open
esensar added a commit to esensar/vector that referenced this issue Dec 23, 2024
@esensar
feat(tag_cardinality_limit transform): enable per metric limits for `…
c2fcd7a 
…tag_cardinality_limit`

This adds the ability to add per metric limits in `tag_cardinality_limit` transform, besides the
global configuration that applies to all metrics. It supports matching metrics by name and
optionally by namespace too.

Closes: vectordotdev#15743
@esensar esensar linked a pull request Dec 23, 2024 that will close this issue
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
transform: tag_cardinality_limit Anything `tag_cardinality_limit` transform related type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Milestone
No milestone
4 participants
@jszwedko @NasAmin @kaarolch @mbibaud