Fixes

vectordotdev · Oct 20, 2023 · a8758d8 · a8758d8
1 parent e8e8a9c
commit a8758d8
Show file tree

Hide file tree

Showing 6 changed files with 27 additions and 8 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/lib/vector-stream/Cargo.toml b/lib/vector-stream/Cargo.toml
@@ -17,3 +17,8 @@ tracing = { version = "0.1.34", default-features = false }
 twox-hash = { version = "1.6.3", default-features = false }
 vector-common = { path = "../vector-common" }
 vector-core = { path = "../vector-core" }
+
+[dev-dependencies]
+proptest = "1.3"
+rand = "0.8.5"
+rand_distr = "0.4.3"
diff --git a/lib/vector-stream/src/batcher/mod.rs b/lib/vector-stream/src/batcher/mod.rs
@@ -119,7 +119,7 @@ mod test {
     use futures::stream;
 
     use super::*;
-    use crate::stream::BatcherSettings;
+    use crate::BatcherSettings;
 
     #[tokio::test]
     async fn item_limit() {

diff --git a/lib/vector-stream/src/driver.rs b/lib/vector-stream/src/driver.rs
@@ -293,7 +293,7 @@ mod tests {
     }
 
     impl Finalizable for DelayRequest {
-        fn take_finalizers(&mut self) -> crate::event::EventFinalizers {
+        fn take_finalizers(&mut self) -> vector_core::event::EventFinalizers {
             std::mem::take(&mut self.1)
         }
     }
@@ -365,6 +365,7 @@ mod tests {
             let upper = self.upper_bound_us;
 
             // Generate a value between 10ms and 500ms, with a long tail shape to the distribution.
+            #[allow(clippy::cast_sign_loss)] // Value will be positive anyways
             self.jitter
                 .sample_iter(&mut self.jitter_gen)
                 .map(|n| n * lower as f64)

diff --git a/lib/vector-stream/src/lib.rs b/lib/vector-stream/src/lib.rs
@@ -1,3 +1,15 @@
+#![deny(warnings)]
+#![deny(clippy::all)]
+#![deny(clippy::pedantic)]
+#![deny(unreachable_pub)]
+#![deny(unused_allocation)]
+#![deny(unused_extern_crates)]
+#![deny(unused_assignments)]
+#![deny(unused_comparisons)]
+#![allow(clippy::module_name_repetitions)]
+#![allow(clippy::must_use_candidate)]
+#![allow(clippy::type_complexity)]
+
 pub mod batcher;
 mod concurrent_map;
 mod driver;

diff --git a/lib/vector-stream/src/partitioned_batcher.rs b/lib/vector-stream/src/partitioned_batcher.rs
@@ -346,6 +346,7 @@ where
     }
 }
 
+#[allow(clippy::cast_sign_loss)]
 #[cfg(test)]
 mod test {
     use std::{
@@ -360,14 +361,11 @@ mod test {
     use pin_project::pin_project;
     use proptest::prelude::*;
     use tokio::{pin, time::advance};
+    use vector_core::{partition::Partitioner, time::KeyedTimer};
 
     use crate::{
-        partition::Partitioner,
-        stream::{
-            partitioned_batcher::{ExpirationQueue, PartitionedBatcher},
-            BatcherSettings,
-        },
-        time::KeyedTimer,
+        partitioned_batcher::{ExpirationQueue, PartitionedBatcher},
+        BatcherSettings,
     };
 
     #[derive(Debug)]