Skip to content

Commit

Permalink
fix(socket source): remove default_max_length default (#16631)
Browse files Browse the repository at this point in the history
* Remove default_max_length default

Signed-off-by: Stephen Wakely <[email protected]>

* Remove default_max_length default from unix

Signed-off-by: Stephen Wakely <[email protected]>

* Update configurable docs

Signed-off-by: Stephen Wakely <[email protected]>

---------

Signed-off-by: Stephen Wakely <[email protected]>
  • Loading branch information
StephenWakely authored and jszwedko committed Mar 3, 2023
1 parent 0840615 commit 73bf872
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
1 change: 0 additions & 1 deletion src/sources/socket/tcp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ pub struct TcpConfig {
deprecated = "This option has been deprecated. Configure `max_length` on the framing config instead."
)]
#[configurable(metadata(docs::type_unit = "bytes"))]
#[serde(default = "default_max_length")]
max_length: Option<usize>,

/// The timeout before a connection is forcefully closed during shutdown.
Expand Down
1 change: 0 additions & 1 deletion src/sources/socket/unix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ pub struct UnixConfig {
#[configurable(
deprecated = "This option has been deprecated. Configure `max_length` on the framing config instead."
)]
#[serde(default = "default_max_length")]
#[configurable(metadata(docs::type_unit = "bytes"))]
pub max_length: Option<usize>,

Expand Down
5 changes: 1 addition & 4 deletions website/cue/reference/components/sources/base/socket.cue
Original file line number Diff line number Diff line change
Expand Up @@ -189,10 +189,7 @@ base: components: sources: socket: configuration: {
Messages larger than this are truncated.
"""
required: false
type: uint: {
default: 102400
unit: "bytes"
}
type: uint: unit: "bytes"
}
mode: {
description: "The type of socket to use."
Expand Down

0 comments on commit 73bf872

Please sign in to comment.