Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

Parse Lambda log messages #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asprouse
Copy link

@asprouse asprouse commented May 5, 2018

This PR parses the Lambda usage report log messages. Perhaps there needs to be an environment variable to disable this behavior but it would seem that most people use this function to integrate with Lambda

@zsherman zsherman requested a review from binarylogic May 5, 2018 18:37
@ghost ghost requested review from a user and removed request for binarylogic May 30, 2018 20:24
@ghost ghost assigned ghost and unassigned binarylogic May 30, 2018
@ghost
Copy link

ghost commented May 30, 2018

@asprouse sorry for the delay in getting back to you on this.

Great work and I agree this is something most users would want and expect.

I only have one request, which is to namespace all custom contextual values under lambda. Right now we have lambda_start, lambda_end, etc., but I think it would be cleaner and more intuitive to have them all under lambda unless you have a specific use case in mind for the different event types.

Ultimately I think we will include lambda as a known context in our schema, but this is a good solution for the interim.

@ghost
Copy link

ghost commented May 31, 2018

@asprouse scratch what I said before. We will be making schema changes related to lambda and then update this code accordingly.

@asprouse
Copy link
Author

@carkmorwin roger that. Let me know when the when the new version drops.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants