Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a proper user agent #225

Closed
Johennes opened this issue Oct 6, 2022 · 0 comments · Fixed by #226
Closed

Add a proper user agent #225

Johennes opened this issue Oct 6, 2022 · 0 comments · Fixed by #226

Comments

@Johennes
Copy link
Contributor

Johennes commented Oct 6, 2022

Is your feature request related to a problem? Please describe.

The current user agent is "rust-sdk-ios" which isn't very descriptive and limits the usefulness of features such as the upcoming device manager.

Describe the solution you'd like

Element X should use the standard user agent format similar to what Element iOS does.

Describe alternatives you've considered

Additional context

With matrix-org/matrix-rust-sdk#1078 it's now possible to specify the user agent when initializing the SDK.

Johennes added a commit that referenced this issue Oct 6, 2022
@Johennes Johennes mentioned this issue Oct 6, 2022
7 tasks
stefanceriu pushed a commit that referenced this issue Oct 28, 2022
* Set a proper user agent
* Add fallback when UA comes out nil
* Remove unused Bundle extension
* Return nil when asciification fails
* Add whitespace handling and further emoji test case
* Explicitly check if string is already in ASCII
* Rename factory to builder
* Use allSatisfy instead of reduce
* Use key path syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant