-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a proper user agent #226
Conversation
Fixes: #225
Generated by 🚫 Danger Swift against 3c135e6 |
Codecov ReportBase: 36.26% // Head: 36.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #226 +/- ##
===========================================
+ Coverage 36.26% 36.49% +0.23%
===========================================
Files 214 215 +1
Lines 14383 14447 +64
Branches 7086 7111 +25
===========================================
+ Hits 5216 5273 +57
- Misses 9039 9046 +7
Partials 128 128
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
As the SDK was updated this is now ready for review. I believe the LFS quota errors are unrelated to my changes but please let me know otherwise. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 👍
This applies a proper user agent to EX which enables more detailed display of EX sessions in Element's device manager.
This depends on matrix-org/matrix-rust-sdk#1078 so will only be able to move forward once the SDK has been updated to a version that includes this change.
Fixes #225
Pull Request Checklist
UI changes have been tested with: