Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a proper user agent #226

Merged
merged 11 commits into from
Oct 28, 2022
Merged

Set a proper user agent #226

merged 11 commits into from
Oct 28, 2022

Conversation

Johennes
Copy link
Contributor

@Johennes Johennes commented Oct 6, 2022

This applies a proper user agent to EX which enables more detailed display of EX sessions in Element's device manager.

This depends on matrix-org/matrix-rust-sdk#1078 so will only be able to move forward once the SDK has been updated to a version that includes this change.

Fixes #225

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

@Johennes Johennes marked this pull request as draft October 6, 2022 19:50
@Johennes Johennes marked this pull request as ready for review October 27, 2022 06:31
@github-actions
Copy link

github-actions bot commented Oct 27, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 3c135e6

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 36.26% // Head: 36.49% // Increases project coverage by +0.23% 🎉

Coverage data is based on head (3c135e6) compared to base (3be0afd).
Patch coverage: 90.47% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #226      +/-   ##
===========================================
+ Coverage    36.26%   36.49%   +0.23%     
===========================================
  Files          214      215       +1     
  Lines        14383    14447      +64     
  Branches      7086     7111      +25     
===========================================
+ Hits          5216     5273      +57     
- Misses        9039     9046       +7     
  Partials       128      128              
Flag Coverage Δ
unittests 12.16% <90.47%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/Services/UserSessionStore/UserSessionStore.swift 0.00% <0.00%> (ø)
ElementX/Sources/Other/Extensions/String.swift 65.00% <75.00%> (+6.66%) ⬆️
ElementX/Sources/Other/UserAgentBuilder.swift 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Johennes
Copy link
Contributor Author

As the SDK was updated this is now ready for review. I believe the LFS quota errors are unrelated to my changes but please let me know otherwise.

UnitTests/Sources/StringTests.swift Show resolved Hide resolved
ElementX/Sources/Other/UserAgentFactory.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/Extensions/Bundle.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/UserAgentFactory.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/UserAgentFactory.swift Outdated Show resolved Hide resolved
ElementX/Sources/Other/UserAgentFactory.swift Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu self-requested a review October 28, 2022 09:05
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff 👍

@stefanceriu stefanceriu merged commit 09b2f93 into develop Oct 28, 2022
@stefanceriu stefanceriu deleted the johannes/user-agent branch October 28, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a proper user agent
2 participants