Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the exclamation point from new invites #5249

Closed
3 tasks
daniellekirkwood opened this issue Dec 6, 2021 · 3 comments · Fixed by #5684
Closed
3 tasks

Remove the exclamation point from new invites #5249

daniellekirkwood opened this issue Dec 6, 2021 · 3 comments · Fixed by #5684
Assignees
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort

Comments

@daniellekirkwood
Copy link
Contributor

daniellekirkwood commented Dec 6, 2021

Problem

When a user is invited to a room, it's startling and can be scary to accept because of the exclamation point and the inability to get rid of it. The Android solution draws the same attention to invites, but does not cause such alarm.

Solution

Remove the exclamation point completely. Bring the iOS version inline with the Android implementation and make the whole invite section collapsible.

  • Make indicator number, not exclamation point
  • Move indicator to Invite header
  • Make invite section collapsible
from to
Screenshot 2021-12-13 12 46 20 image
@daniellekirkwood daniellekirkwood added T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-WTF WTF issues: High impact, Low Effort labels Dec 6, 2021
@daniellekirkwood
Copy link
Contributor Author

Related to #5222

@daniellekirkwood daniellekirkwood added the Z-Ready This issue is ready for development label Jan 26, 2022
@MaximeEvrard42 MaximeEvrard42 self-assigned this Feb 8, 2022
@MaximeEvrard42 MaximeEvrard42 removed their assignment Feb 11, 2022
@MaximeEvrard42 MaximeEvrard42 changed the title Remove the exclamation point from new invites 5 Feb 11, 2022
@MaximeEvrard42 MaximeEvrard42 changed the title 5 Remove the exclamation point from new invites Feb 11, 2022
@aringenbach aringenbach self-assigned this Feb 16, 2022
@aringenbach
Copy link
Contributor

Hello @amshakal , we have identified the whole header for invitations + collapsible as being rather complicated due to some legacy code.
As a smaller step towards a better experience, I made it a bit nicer/closer to Android.
It seems to me that is pretty clear that I can take an action here without the ! indicator (+ there is indicators on the bottom tab bar that are related to these invites). WDYT ?

@daniellekirkwood
Copy link
Contributor Author

daniellekirkwood commented Feb 17, 2022

If we can't collapse the section then we should be cautious about making the invite cell larger than it is today.

Design and Engineering are working together in Figma to find a solution :)

@aringenbach can you please update #5222 with a comment about the collapsible sections when you have a second?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Ready This issue is ready for development Z-WTF WTF issues: High impact, Low Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants