Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exclamation mark badge in invites cell #5684

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

aringenbach
Copy link
Contributor

Fixes #5249

@github-actions
Copy link

github-actions bot commented Feb 23, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vJem35

@pixlwave
Copy link
Member

Probably more of a question for @amshakal / @daniellekirkwood, but do we need to have the shouty buttons? I think that's more of an Android design than an iOS one.

@aringenbach aringenbach changed the title Remove exclamation mark and improve global design in invites cell Remove exclamation mark badge in invites cell Feb 24, 2022
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Sorry we undid some of your work during office hours 😕

@aringenbach aringenbach merged commit 00c5d5a into develop Feb 25, 2022
@aringenbach aringenbach deleted the aringenbach/5249_rework_invitation_cell branch February 25, 2022 09:45
@aringenbach
Copy link
Contributor Author

No worries, office hours are there to pick out only the best in our features as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the exclamation point from new invites
2 participants