Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload with APIv2 #138

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Upload with APIv2 #138

merged 2 commits into from
Dec 18, 2024

Conversation

ofermend
Copy link
Collaborator

Enable file_upload with APIv2 using data table understanding

sulekz
sulekz approved these changes Dec 17, 2024
View reviewed changes
Copy link

@sulekz sulekz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to deprecate v1 indexing? This would eliminate the need for the corpus_key as well as corpus_id to be passed to the crawler.

@ofermend
Copy link
Collaborator Author

Soon. Planning a major upgrade to APIv2 (Shane already started on it), but this would be mid-way step.

@ofermend ofermend merged commit aa258b6 into main Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulekz sulekz sulekz approved these changes

@justinhayes justinhayes Awaiting requested review from justinhayes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofermend @sulekz