Store docs locally #119
Merged
Store docs locally #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added store_docs configuration option to store all file content locally
justinhayes
reviewed
Sep 16, 2024
core/utils.py
Outdated
| if mime_type in ['text/html', 'application/xml', 'text/xml']: | ||
| with open(file_path, 'r', encoding='utf-8') as file: | ||
| first_1024_bytes = file.read(1024) | ||
| if '<html' in first_1024_bytes.lower() and '</html>' in first_1024_bytes.lower(): |
There was a problem hiding this comment.
Why is this looking for the closing html tag in the first 1024 bytes? Shouldn't that be looked for in the last 1024 bytes?
There was a problem hiding this comment.
It is actually okay since usually XML files look this way (very close start/end HTML tags), but let me see if I can figure out a more robust detection option.
justinhayes
reviewed
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed issue with detect_file_type
added store_docs configuration option to store all file content locally