google drive crawler #101
Merged
google drive crawler #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofermend
reviewed
Jul 3, 2024
ofermend
reviewed
Jul 3, 2024
added 3 commits
July 10, 2024 16:36
…age for processed files, and handling PDF files
ofermend
reviewed
Jul 13, 2024
ofermend
reviewed
Jul 13, 2024
ofermend
reviewed
Jul 13, 2024
ofermend
reviewed
Jul 13, 2024
ofermend
reviewed
Jul 13, 2024
…mparison, and rename byte_stream
ofermend
reviewed
Jul 16, 2024
ofermend
reviewed
Jul 17, 2024
requirements.txt
Outdated
| @@ -19,7 +19,8 @@ biopython==1.81 | |||
| boto3==1.26.116 | |||
| mwviews==0.2.1 | |||
| toml==0.10.2 | |||
| pandas==1.3.5 | |||
| pandas==2.2.2 | |||
There was a problem hiding this comment.
Why do we need to upgrade pandas and numpy?
This may break other things, so unless it's tested thoroughly I would avoid without a specific need.
ofermend
reviewed
Jul 17, 2024
ofermend
reviewed
Jul 17, 2024
ofermend
reviewed
Jul 17, 2024
| self.creds = get_credentials(user) | ||
| self.service = build("drive", "v3", credentials=self.creds) | ||
|
|
||
| list_files = self.list_files(self.service, date_threshold=date_threshold.isoformat() + 'Z') |
There was a problem hiding this comment.
I see you using the ISO format + "z": is this because Google API demands it to be in UTC format and in this way?
ofermend
reviewed
Jul 17, 2024
crawlers/gdrive_crawler.py
Outdated
|
|
||
| list_files = self.list_files(self.service, date_threshold=date_threshold.isoformat() + 'Z') | ||
| for file in list_files: | ||
| modified_time = file.get('modifiedTime', None) |
There was a problem hiding this comment.
This is unneeded. The date_threshold check was already done in list_files() so here all files should already be in the right date range.
added 3 commits
July 17, 2024 13:56
ofermend
reviewed
Jul 17, 2024
Dockerfile
Outdated
| @@ -34,6 +34,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
| # install python packages | |||
| WORKDIR ${HOME} | |||
| COPY requirements.txt requirements-extra.txt $HOME/ | |||
| COPY crawlers/credentials.json $HOME/ | |||
There was a problem hiding this comment.
This is not a good idea. I'll explain offline why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vectara-gdrive.yamlfor the google drive under the folderconfig.gdrive_crawler.pyunder the foldercrawlersingest.pyrequirements.txt