feat: node management, endorsing and gm #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
- Coverage 96.79% 93.90% -2.90%
==========================================
Files 48 55 +7
Lines 3437 3463 +26
Branches 474 774 +300
==========================================
- Hits 3327 3252 -75
- Misses 109 211 +102
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
roisindowling
force-pushed
the
endors
branch
from
9cc5aa1
to
650d853
Compare
Agilulfo1820
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
X2EarnAppsto Version 2Added Vechain Node XApp Endorsement feature.
Changes 🚀
X2EarnApps.solto version2Storage Changes 📦
EndorsementUpgradeable.sol:_unendorsedAppsto store the list of apps pending endorsement._unendorsedAppsIndexto store mapping from app ID to index in the _unendorsedApps array._appEndorsersto store the mapping of each app ID to an array of node IDs that have endorsed it._nodeEnodorsmentScoreto score the endorsement score for each node level._appGracePeriodStartto store the grace period elapsed by the app since endorsed._nodeToEndorsedAppto store the mapping of a node ID to the app it currently endorses._gracePeriodDurationto store the grace period threshold for no endorsement in blocks._endorsementScoreThresholdto store the endorsement score threshold for an app to be eligible for voting._appScoresto store the score of each app._appSecurityto store the security score of each app._nodeManagementContractto store the node management contract address._veBetterPassportto store the VeBetterPassport contract address.EndorsementUpgradeable.sol:_creatorsto store a mapping of addresses that have a creators NFT and can manage interactions with Node holders for a specifc XApp._creatorAppsto store the number of apps created by a creator._x2EarnCreatorContractto store the address of the X2Earn Creators contract.VoteEligibilityUpgradeable.sol:_blackListto store a record blacklisted X2Earn appIds.New Features 🚀
EndorsementUpgradeable.solmodule which makes up all X2EarnApps endorsement logic and functions (see docs for more info).appApp()withsubmitApp().isBlacklisted()to check if XApp is blacklisted.removeAppCreator(),appCreators(),isAppCreator()andcreatorApps()to manage and get info on X2Earn app creators.Bug Fixes 🐛
AdministrationUtils.sol,EndorsementUtils.sol,AppStorageUtils.solandVoteEligibilityUtils.solto store some of the logic for the X2EarnApps contracts modules to reduce contract size.