Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli option for limit-per-account in the mempool #815

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

MakisChristou
Copy link
Member

This PR makes the already existing flags

  • txpool-limit-per-account (default 16)
  • txpool-limit (default 10k)

which were previously solo only flags available in testnet and mainnet modes. No unbounded option was added but we can discuss if that is necessary.

@MakisChristou MakisChristou requested a review from a team as a code owner August 13, 2024 12:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 62.53%. Comparing base (e6c91cb) to head (d6b7dbd).
Report is 7 commits behind head on master.

Files Patch % Lines
cmd/thor/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #815      +/-   ##
==========================================
+ Coverage   62.08%   62.53%   +0.44%     
==========================================
  Files         203      203              
  Lines       18723    18731       +8     
==========================================
+ Hits        11624    11713      +89     
+ Misses       5997     5920      -77     
+ Partials     1102     1098       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/thor/flags.go Outdated Show resolved Hide resolved
cmd/thor/main.go Outdated Show resolved Hide resolved
Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Do you think it is worth creating a test for the limit per account ?

@leszek-vechain
Copy link
Contributor

would be nice to have for sure, just to ensure that this change works as expected

@MakisChristou
Copy link
Member Author

lgtm 👍

Do you think it is worth creating a test for the limit per account ?

Do you mean e2e tests or unit tests. Because there are already some unit tests for the account limit.

@otherview otherview merged commit 8ba7f54 into vechain:master Aug 19, 2024
12 checks passed
@otherview
Copy link
Member

lgtm 👍
Do you think it is worth creating a test for the limit per account ?

Do you mean e2e tests or unit tests. Because there are already some unit tests for the account limit.

Yeah, It guess that's fine, not worth the whole setup for the tx per account test.
Good stuff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants