Justified revision #802
Merged
Justified revision #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
==========================================
+ Coverage 62.33% 62.36% +0.03%
==========================================
Files 206 208 +2
Lines 18859 18904 +45
==========================================
+ Hits 11756 11790 +34
- Misses 6002 6009 +7
- Partials 1101 1105 +4 ☔ View full report in Codecov by Sentry. |
|
can we add test for justified in e2e ? (we can open PR for now and just merge it when needed, before we forget about it) |
libotony
reviewed
Aug 5, 2024
Tests added in this PR. |
|
@paologalligit I had a non-persist way, if you have a bit, please take a look #808 |
darrenvechain
previously approved these changes
Aug 9, 2024
libotony
previously approved these changes
Aug 9, 2024
otherview
reviewed
Aug 9, 2024
paologalligit
dismissed stale reviews from darrenvechain and libotony
via
c661c61
otherview
previously approved these changes
Aug 21, 2024
darrenvechain
previously approved these changes
Aug 21, 2024
otherview
approved these changes
Sep 4, 2024
libotony
approved these changes
Sep 4, 2024
libotony
added a commit
that referenced
this pull request
Sep 6, 2024
* feature: add justified revision for block * fix: missing err declaration * docs: add justified revision to thor.yaml * feat: storing justified blockId in engine.data * a non-persist way to implement jutified * use store point to restore quality * refactor: rename CommitLevel interface * refactor: change approach to non-persist the justified block * bft: add justified tests * fix: rename file name and simplified error check in test * improve bft package * add comments --------- Co-authored-by: tony <[email protected]> Co-authored-by: otherview <[email protected]> Co-authored-by: Darren Kelly <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refers to this ticket. It introduces a new revision named justified. The meaning of this revision is the same Ethereum is using (see here, in geth the justified revision is referred to as safe). The chain is composed of epochs (each epoch is composed of 180 blocks) whose starting point is called checkpoint. When an epoch ends, if its checkpoint has garnered a ⅔ supermajority, the checkpoint gets justified; this happens every 30 minutes.
Example:
-- current best block
|
|
-- checkpoint
|
|
|
|
|
-- justified checkpoint
|
|
|
|
|
-- finalized checkpoint
Type of change
How Has This Been Tested?
Checklist: