Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VeTools Milestone 1 Submission #183

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Conversation

hazelcaus
Copy link
Contributor

Milestone Submission

All deliverables completed per agreement. Additionally, VeTools v1.0.0 is live on the VSCode Marketplace. Source code: https://github.com/hazelcaus/vetools

@hazelcaus
Copy link
Contributor Author

@NecoSherry @libotony

@NecoSherry NecoSherry added the milestone delivery Submission of completed milestones label Oct 31, 2023
@libotony
Copy link
Member

Hi @hazelcaus, thank you for the milestone delivery, can you provide some info regarding the result of the delivery, e.g. screenshots, documents, etc? And the source code seems to be a private repo, I can not access it.

@hazelcaus
Copy link
Contributor Author

@libotony I have made the repo public!

@libotony
Copy link
Member

@libotony I have made the repo public!

Yes, I can see the code, I understand it's still the early stage of your project and there is not much document. To verify the milestone, could you provide some screenshots,videos, gifs for proving the delivery?

@hazelcaus
Copy link
Contributor Author

Thanks @libotony for the suggestions. I have added some testing instructions and demos to the repo. Hope this helps!

@hazelcaus
Copy link
Contributor Author

@libotony

@libotony
Copy link
Member

libotony commented Nov 8, 2023

@libotony

Hi @hazelcaus thank you for the feedback, I have tried the first step, but I got an error
Screenshot 2023-11-08 at 18 52 11

@hazelcaus
Copy link
Contributor Author

That's strange @libotony. It's working fine for me. See: https://streamable.com/e/4yx8jz. Can you confirm if you're on the latest version?

@libotony
Copy link
Member

libotony commented Nov 9, 2023

That's strange @libotony. It's working fine for me. See: https://streamable.com/e/4yx8jz. Can you confirm if you're on the latest version?

Yes, it's the latest version and I think it's the only version that published to the marketplace.

@hazelcaus
Copy link
Contributor Author

Huh, I literally just recorded this video and it was working fine for me.

@libotony
Copy link
Member

libotony commented Nov 9, 2023

Extension Host is reporting You don't have npm installed. Please install before continuing and I have npm installed.

@hazelcaus
Copy link
Contributor Author

Here's another video I recorded demonstrating that it works properly. Also, could you take a screenshot(s) of the Output -> VeTools section (shown in the video section). Could help with some debugging...
@libotony

@libotony
Copy link
Member

libotony commented Nov 9, 2023

Here's another video I recorded demonstrating that it works properly. Also, could you take a screenshot(s) of the Output -> VeTools section (shown in the video section). Could help with some debugging... @libotony

Only one line vetools>>> 9.8.0

@hazelcaus
Copy link
Contributor Author

@libotony thanks for the feedback. I have made a change in the code where if the installation fails, it prompts you to manually run npm install or yarn install. Please update your extension version (to v1.0.1) and let me know if it works!

@libotony
Copy link
Member

@libotony thanks for the feedback. I have made a change in the code where if the installation fails, it prompts you to manually run npm install or yarn install. Please update your extension version (to v1.0.1) and let me know if it works!

Thanks for the update, I have successfully created a new vetools project. But I can not find the command VeTools: Compile Contracts.
Screenshot 2023-11-14 at 12 30 37

@hazelcaus
Copy link
Contributor Author

My bad. I disabled that feature when testing for your bug, and kept it disabled in v1.0.1. Please update to v1.0.2, and you should be able to compile your contracts successfully. Thanks

@libotony
Copy link
Member

My bad. I disabled that feature when testing for your bug, and kept it disabled in v1.0.1. Please update to v1.0.2, and you should be able to compile your contracts successfully. Thanks

Thanks for the update, the compile command has shown after upgrading to v1.0.2. However, the command failed to execute.
Screenshot 2023-11-15 at 10 11 35

And output shows:

vetools>>> /bin/sh: node: command not found

@hazelcaus
Copy link
Contributor Author

hazelcaus commented Nov 15, 2023

okay, I'm very confused as to why this error is visible for you. I've tried this on different machines (and OSes), but it works perfectly fine for me. What's happening under the hood of the extension is we spin up a child process and execute shell commands (like getting npm or node versions). With your initial error and the error you've got today, my guess is that node and npm are not added in your PATH correctly (particularly in a bash shell: /bin/sh).

That said, could I request if you could install Node Version Manager (nvm) -- it could possibly help correct any faulty installations, PATH additions, and old versions. I've also released v1.0.3 of the extension and added more debugging information.

I apologize for the back-and-forth, but this is the fastest way to debug this issue(s) across different computers. Alternatively, I'm happy to send you a screen recording of the extension working across different systems.

Also, please kindly run the following in your terminal and confirm the versions for me (verify if you get any errors across different terminal sessions like ZSH, and BASH). Thanks!

npm --version
node --version
nvm version # if you've installed above

@libotony
Copy link
Member

okay, I'm very confused as to why this error is visible for you. I've tried this on different machines (and OSes), but it works perfectly fine for me. What's happening under the hood of the extension is we spin up a child process and execute shell commands (like getting npm or node versions). With your initial error and the error you've got today, my guess is that node and npm are not added in your PATH correctly (particularly in a bash shell: /bin/sh).

That said, could I request if you could install Node Version Manager (nvm) -- it could possibly help correct any faulty installations, PATH additions, and old versions. I've also released v1.0.3 of the extension and added more debugging information.

I apologize for the back-and-forth, but this is the fastest way to debug this issue(s) across different computers. Alternatively, I'm happy to send you a screen recording of the extension working across different systems.

Also, please kindly run the following in your terminal and confirm the versions for me (verify if you get any errors across different terminal sessions like ZSH, and BASH). Thanks!

npm --version
node --version
nvm version # if you've installed above

I have two MacBook for testing,

The first one, nvm installed, v1.0.3 tells command 'vetools.newProject' not found and command 'vetools.buildContracts' not found, sh/bash/zsh can show node version.

The second one, node is installed via brew, same as above, v1.0.3 tells command 'vetools.newProject' not found and command 'vetools.buildContracts' not found, sh/bash/zsh can show node version.

They both showing the same output:

try_execute >>> workingDirectory: undefined
commands: node
args: --version

vetools>>> /bin/sh: node: command not found
check_apps>>> Current state for versions: [{"app":"node","isValid":false,"required_version":{"max":"17.0.0","min":"14.0.0"},"version":""}] Invalid: true

@hazelcaus
Copy link
Contributor Author

hazelcaus commented Nov 15, 2023

Just to be clear: in v1.0.3, "New Project" and "Compile Contracts" both don't work? Or just the latter?

Here's my output (also on a Mac)
Screenshot 2023-11-15 at 10 06 22

@libotony
Copy link
Member

Just to be clear: in v1.0.3, "New Project" and "Compile Contracts" both don't work? Or just the latter?

Here's my output (also on a Mac) Screenshot 2023-11-15 at 10 06 22

Both don't work, I also asked my colleagues to verify.

@hazelcaus
Copy link
Contributor Author

@libotony I might be on to something (and figured out the error). Pushing a fix now...

@hazelcaus
Copy link
Contributor Author

@libotony please update to v1.0.4 and let me know if you're able to compile contracts successfully. Also, would suggest you start over with VeTools: New Project if you're not already doing that. Made some changes in v1.0.2 that might cause an error when compiling contracts

@libotony
Copy link
Member

@libotony please update to v1.0.4 and let me know if you're able to compile contracts successfully. Also, would suggest you start over with VeTools: New Project if you're not already doing that. Made some changes in v1.0.2 that might cause an error when compiling contracts

Thank you for the update, it's working perfectly!

@libotony
Copy link
Member

libotony commented Nov 15, 2023

I noticed that you are using @vechain.energy/hardhat-thor in the project, it's deprecated due to the foundation published a new one, please take a look https://github.com/vechainfoundation/hardhat-plugins

@hazelcaus
Copy link
Contributor Author

noted. This has been reflected in v1.0.5

@NecoSherry NecoSherry merged commit 2fcd837 into vechain:master Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
milestone delivery Submission of completed milestones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants