Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove swarm packages and related, fix unit tests #9

Merged
merged 11 commits into from
Jul 15, 2024

Conversation

paologalligit
Copy link
Member

This PR removes the entire swarm package since it's not used anymore. It also fixes the unit tests; this way a docker container can be created using the Dockerfile in the repo and used to run tests on github.

@paologalligit paologalligit marked this pull request as ready for review June 19, 2024 14:39
@paologalligit paologalligit requested a review from a team June 19, 2024 14:44
libotony
libotony previously approved these changes Jun 25, 2024
- for now on-pull-request and test
@libotony
Copy link
Member

@paologalligit @leszek-vechain appended 3 commits to make test pass

  1. Removed fuzz test temporarily, since it's not compatible with go 1.10, needs to add it back in the future
  2. Skipped mobile package test, it's not working in go 1.10, and we are not using it, skip for now, seek the possibility to enable it in the future
  3. Removed incompatible test in parseNode, by incompatible I mean not working at go 1.10 but works in go 1.22

After the test and go module PR pass, our next goal might be seeking upgrading to most recent go version, for example go 1.22. But that might take more work to do since there is go API change from go 1.10 to go 1.22.

@leszek-vechain
Copy link

should we close this ticket then and open new one with upgrade to go 1.22 ?

@libotony
Copy link
Member

should we close this ticket then and open new one with upgrade to go 1.22 ?

I would suggest try it first, my previous try shows more places to be fixed.

@paologalligit paologalligit requested a review from libotony July 15, 2024 08:05
@libotony
Copy link
Member

Something wrong with my local GPG signing, let me see how to fix it

@libotony libotony merged commit 2743143 into thor-upstream Jul 15, 2024
1 check passed
@libotony libotony deleted the paolo/gha-fix branch July 15, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants