Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/validate-apps #250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore/validate-apps #250

wants to merge 2 commits into from

Conversation

claytonneal
Copy link
Member

Add script and workflow to check if apps are returning http 404/500 etc

@darrenvechain
Copy link
Member

darrenvechain commented Jan 30, 2024

@claytonneal I believe there is a validation in the validate.ts file:

https://github.com/vechain/app-hub/blob/master/scripts/validate.ts#L110

@libotony
Copy link
Member

How about make it a scheduled workflow? I will change the script to check all apps then report all errors.

@libotony
Copy link
Member

If I am remembering correctly, one app used cloudflare and checkLink reports error but it works at the browser level, maybe that need extra confirm by human.

@libotony
Copy link
Member

How about make it a scheduled workflow? I will change the script to check all apps then report all errors.

script updated #252

Comment on lines +11 to +12
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with:
fetch-depth: 0

validate link does not require full history

Comment on lines +23 to +25
run: npm run validate:links
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
run: npm run validate:links
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: npm run validate:link

validate link does not need a gh token, PR mode needed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks tony!

@fabiofvc
Copy link
Contributor

fabiofvc commented Mar 4, 2024

@claytonneal this issue is super cool! Cant want to see it in prod ;)

Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants