Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Bug fix on StreamGetObject API and DNS cache expiration / refactor net connection #986

Merged
merged 29 commits into from
Feb 9, 2021
Merged

[patch] Bug fix on StreamGetObject API and DNS cache expiration / refactor net connection #986

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
f4e0ad2
refactor net connection
kpango Feb 5, 2021
47cef3f
close unclosed channel
kpango Feb 5, 2021
e659767
fix
kpango Feb 5, 2021
1c68e4e
fix failing test & add insecure option for user
kpango Feb 5, 2021
58d6c07
bugfix
kpango Feb 5, 2021
ccb25cb
add custom connection dialer to k8s
kpango Feb 5, 2021
8abb1a0
fix
kpango Feb 5, 2021
ab422a4
fix e2e test conparator for v1 API
kpango Feb 6, 2021
91c5c20
fix
kpango Feb 6, 2021
f63c78d
fix
kpango Feb 6, 2021
b480b95
fix useless schema annotation for helm charts
kpango Feb 8, 2021
0c0bf84
Merge branch 'master' into refactor/internal-net/more-controllable-tc…
kpango Feb 8, 2021
44f6197
Merge branch 'master' into refactor/internal-net/more-controllable-tc…
kpango Feb 8, 2021
02f575a
change CreateIndex precondition failure log level to Warn from Error …
kpango Feb 8, 2021
7de5261
Merge branch 'refactor/internal-net/more-controllable-tcp-handshake-a…
kpango Feb 8, 2021
5664078
Merge branch 'master' into refactor/internal-net/more-controllable-tc…
kpango Feb 8, 2021
46e67d1
Merge branch 'master' into refactor/internal-net/more-controllable-tc…
kpango Feb 9, 2021
52cb14e
Merge branch 'master' into refactor/internal-net/more-controllable-tc…
kpango Feb 9, 2021
b5ab14e
add generated test & update helm schema
kpango Feb 9, 2021
22987df
update golang version to 1.15.8 inclueds cgo&net/http bugfixes
kpango Feb 9, 2021
2ea7cff
fix incorrect helm resource path
kpango Feb 9, 2021
c2c6b4b
bugfix: add priorityClass namespace to each gateways
kpango Feb 9, 2021
fc4805b
extend wait duration for e2e deploy test
kpango Feb 9, 2021
2d43482
fix pointed out from vankichi
kpango Feb 9, 2021
f37f012
fix failed test
kpango Feb 9, 2021
d0c1eed
format
kpango Feb 9, 2021
f2385ee
Update internal/tls/option_test.go
kpango Feb 9, 2021
791896d
Merge branch 'master' into refactor/internal-net/more-controllable-tc…
kpango Feb 9, 2021
06aa294
fix failed test
kpango Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/e2e-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
go test \
-v tests/e2e/crud_test.go \
-tags "e2e" \
-timeout 15m \
-timeout 30m \
-host=localhost \
-port=8081 \
-dataset=`pwd`/hack/benchmark/assets/dataset/${DATASET} \
Expand All @@ -143,7 +143,7 @@ jobs:
-get-object-num=5 \
-update-num=2 \
-remove-num=2 \
-wait-after-insert=3m \
-wait-after-insert=10m \
-portforward \
-portforward-ns=default \
-portforward-pod-name=${podname} \
Expand Down Expand Up @@ -255,7 +255,7 @@ jobs:
go test \
-v tests/e2e/crud_test.go \
-tags "e2e" \
-timeout 15m \
-timeout 30m \
-host=localhost \
-port=8081 \
-dataset=`pwd`/hack/benchmark/assets/dataset/${DATASET} \
Expand All @@ -265,7 +265,7 @@ jobs:
-get-object-num=10 \
-update-num=3 \
-remove-num=2 \
-wait-after-insert=3m \
-wait-after-insert=10m \
-portforward \
-portforward-ns=default \
-portforward-pod-name=${podname} \
Expand Down
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,15 +234,15 @@ SHELL = bash

E2E_BIND_HOST ?= 127.0.0.1
E2E_BIND_PORT ?= 8082
E2E_TIMEOUT ?= 15m
E2E_TIMEOUT ?= 30m
E2E_DATASET_NAME ?= fashion-mnist-784-euclidean
E2E_INSERT_COUNT ?= 1000
E2E_INSERT_COUNT ?= 10000
E2E_SEARCH_COUNT ?= 1000
E2E_SEARCH_BY_ID_COUNT ?= 10
E2E_SEARCH_BY_ID_COUNT ?= 100
E2E_GET_OBJECT_COUNT ?= 10
E2E_UPDATE_COUNT ?= 3
E2E_UPDATE_COUNT ?= 10
E2E_REMOVE_COUNT ?= 3
E2E_WAIT_FOR_CREATE_INDEX_DURATION ?= 3m
E2E_WAIT_FOR_CREATE_INDEX_DURATION ?= 8m
E2E_TARGET_NAME ?= vald-meta-gateway
E2E_TARGET_POD_NAME ?= $(eval E2E_TARGET_POD_NAME := $(shell kubectl get pods --selector=app=$(E2E_TARGET_NAME) | tail -1 | cut -f1 -d " "))$(E2E_TARGET_POD_NAME)
E2E_TARGET_NAMESPACE ?= default
Expand Down
3 changes: 3 additions & 0 deletions charts/vald/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,7 @@ tls:
cert: {{ default .default.tls.cert .Values.tls.cert | quote }}
key: {{ default .default.tls.key .Values.tls.key | quote }}
ca: {{ default .default.tls.ca .Values.tls.ca | quote }}
insecure_skip_verify: {{ default .default.tls.insecure_skip_verify .Values.tls.insecure_skip_verify }}
{{- else }}
{{- toYaml .default.tls | nindent 2 }}
{{- end }}
Expand Down Expand Up @@ -551,6 +552,7 @@ dial_option:
cert: {{ default .default.dial_option.tcp.tls.cert .Values.dial_option.tcp.tls.cert | quote }}
key: {{ default .default.dial_option.tcp.tls.key .Values.dial_option.tcp.tls.key | quote }}
ca: {{ default .default.dial_option.tcp.tls.ca .Values.dial_option.tcp.tls.ca | quote }}
insecure_skip_verify: {{ default .default.dial_option.tcp.tls.insecure_skip_verify .Values.dial_option.tcp.tls.insecure_skip_verify }}
{{- else }}
{{- toYaml .default.dial_option.tcp.tls | nindent 6 }}
{{- end }}
Expand All @@ -574,6 +576,7 @@ tls:
cert: {{ default .default.tls.cert .Values.tls.cert | quote }}
key: {{ default .default.tls.key .Values.tls.key | quote }}
ca: {{ default .default.tls.ca .Values.tls.ca | quote }}
insecure_skip_verify: {{ default .default.tls.insecure_skip_verify .Values.tls.insecure_skip_verify }}
{{- else }}
{{- toYaml .default.tls | nindent 2 }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/templates/gateway/backup/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ spec:
{{- end }}
{{- if $gateway.podPriority }}
{{- if $gateway.podPriority.enabled }}
priorityClassName: {{ $gateway.name }}-priority
priorityClassName: {{ .Release.Namespace }}-{{ $gateway.name }}-priority
{{- end }}
{{- end }}
status:
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/templates/gateway/backup/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ spec:
{{- end }}
{{- if $gateway.podPriority }}
{{- if $gateway.podPriority.enabled }}
priorityClassName: {{ $gateway.name }}-priority
priorityClassName: {{ .Release.Namespace }}-{{ $gateway.name }}-priority
{{- end }}
{{- end }}
status:
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/templates/gateway/filter/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ spec:
{{- end }}
{{- if $gateway.podPriority }}
{{- if $gateway.podPriority.enabled }}
priorityClassName: {{ $gateway.name }}-priority
priorityClassName: {{ .Release.Namespace }}-{{ $gateway.name }}-priority
{{- end }}
{{- end }}
status:
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/templates/gateway/filter/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ spec:
{{- end }}
{{- if $gateway.podPriority }}
{{- if $gateway.podPriority.enabled }}
priorityClassName: {{ $gateway.name }}-priority
priorityClassName: {{ .Release.Namespace }}-{{ $gateway.name }}-priority
{{- end }}
{{- end }}
status:
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/templates/gateway/lb/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ spec:
{{- end }}
{{- if $gateway.podPriority }}
{{- if $gateway.podPriority.enabled }}
priorityClassName: {{ $gateway.name }}-priority
priorityClassName: {{ .Release.Namespace }}-{{ $gateway.name }}-priority
{{- end }}
{{- end }}
status:
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/templates/gateway/lb/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ spec:
{{- end }}
{{- if $gateway.podPriority }}
{{- if $gateway.podPriority.enabled }}
priorityClassName: {{ $gateway.name }}-priority
priorityClassName: {{ .Release.Namespace }}-{{ $gateway.name }}-priority
{{- end }}
{{- end }}
status:
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/templates/gateway/meta/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ spec:
{{- end }}
{{- if $gateway.podPriority }}
{{- if $gateway.podPriority.enabled }}
priorityClassName: {{ $gateway.name }}-priority
priorityClassName: {{ .Release.Namespace }}-{{ $gateway.name }}-priority
{{- end }}
{{- end }}
status:
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/templates/gateway/meta/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ spec:
{{- end }}
{{- if $gateway.podPriority }}
{{- if $gateway.podPriority.enabled }}
priorityClassName: {{ $gateway.name }}-priority
priorityClassName: {{ .Release.Namespace }}-{{ $gateway.name }}-priority
{{- end }}
{{- end }}
status:
Expand Down
2 changes: 1 addition & 1 deletion charts/vald/values.schema.json
View file
Open in desktop

Large diffs are not rendered by default.

Loading