Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement internal/errors/worker test #952

Merged
merged 4 commits into from
Feb 4, 2021
Merged

Implement internal/errors/worker test #952

merged 4 commits into from
Feb 4, 2021

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jan 25, 2021 •
edited
Loading

Description:

This PR implements internal/errors/worker error.
Grammar check passed

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.7
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.13.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions[bot]
github-actions bot reviewed Jan 25, 2021
View reviewed changes
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 25, 2021 •
edited
Loading

Codecov Report

Merging #952 (25c730a) into master (c1c6dc0) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
+ Coverage   14.39%   14.46%   +0.06%     
==========================================
  Files         492      493       +1     
  Lines       27843    27904      +61     
==========================================
+ Hits         4008     4035      +27     
- Misses      23597    23623      +26     
- Partials      238      246       +8
Impacted Files Coverage Δ
internal/errors/worker.go 100.00% <ø> (+100.00%) ⬆️
internal/db/storage/blob/s3/reader/reader.go 63.04% <0.00%> (-31.53%) ⬇️
internal/worker/worker.go 82.29% <0.00%> (-1.05%) ⬇️
internal/net/net.go 73.77% <0.00%> (ø)
internal/worker/queue.go 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c6dc0...672313e. Read the comment docs.

hlts2
hlts2 previously approved these changes Jan 25, 2021
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu requested a review from vankichi January 26, 2021 01:14
vankichi
vankichi requested changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check these suggestions

internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
internal/errors/worker_test.go Outdated Show resolved Hide resolved
@kevindiu kevindiu requested review from vankichi and hlts2 February 3, 2021 06:28
@kevindiu
Copy link
Contributor Author

kevindiu commented Feb 3, 2021

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 3, 2021

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-errors-worker-test

@vdaas-ci vdaas-ci force-pushed the test/internal/add-errors-worker-test branch from af2b64f to 7e4e03a Compare February 3, 2021 08:32
vankichi
vankichi previously approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
please get approve from @hlts2 thanks.

hlts2
hlts2 previously approved these changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu
Copy link
Contributor Author

kevindiu commented Feb 4, 2021

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 4, 2021

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-errors-worker-test

@vdaas-ci vdaas-ci dismissed stale reviews from hlts2 and vankichi via 672313e February 4, 2021 01:24
@vdaas-ci vdaas-ci force-pushed the test/internal/add-errors-worker-test branch from 7e4e03a to 672313e Compare February 4, 2021 01:24
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 4, 2021

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

@vankichi
Copy link
Contributor

vankichi commented Feb 4, 2021

/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 4, 2021

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@kevindiu kevindiu merged commit 9c405ba into master Feb 4, 2021
@kevindiu kevindiu deleted the test/internal/add-errors-worker-test branch February 4, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@vankichi vankichi vankichi approved these changes

@hlts2 hlts2 hlts2 left review comments

Assignees
No one assigned
Labels
area/internal priority/low size/L team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevindiu @vdaas-ci @vankichi @hlts2