Add test case for internal/errors/ngt.go #936

hlts2 · 2021-01-20T05:39:59Z

Description:

I added the test cases for internal/errors/ngt.go and comments and refactored implementation code.

refactor

WHY
The output of following code is ngt object uuid not found%!(EXTRA uint32=0) .
https://github.com/vdaas/vald/blob/master/internal/errors/ngt.go#L85
WHAT

I changed from Errorf to New
And I searched for code that uses this implementation.
According to the results of the investigation, this fix had no effect.
https://github.com/vdaas/vald/search?q=ErrUUIDNotFound

The following is a handler that uses insert and delete in the above result, but it is not affected by the wording correction.

handler of Insert

vald/pkg/agent/core/ngt/handler/grpc/handler.go

Line 282 in 5c914a2

func (s *server) Insert(ctx context.Context, req *payload.Insert_Request) (res *payload.Object_Location, err error) {

handler of Delete

vald/pkg/agent/core/ngt/handler/grpc/handler.go

Line 526 in 5c914a2

func (s *server) Remove(ctx context.Context, req *payload.Remove_Request) (res *payload.Object_Location, err error) {

grammar check passed

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.6
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.3

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2021-01-20T05:40:17Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

internal/errors/ngt.go

codecov · 2021-01-20T05:47:59Z

Codecov Report

Merging #936 (4e1b69d) into master (f8abd67) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #936      +/-   ##
==========================================
+ Coverage   15.18%   15.34%   +0.16%     
==========================================
  Files         493      493              
  Lines       25683    25683              
==========================================
+ Hits         3900     3942      +42     
+ Misses      21533    21491      -42     
  Partials      250      250

Impacted Files	Coverage Δ
internal/errors/vald.go	`100.00% <ø> (+100.00%)`	⬆️
internal/errors/ngt.go	`94.11% <100.00%> (+94.11%)`	⬆️
internal/worker/worker.go	`83.33% <0.00%> (+1.04%)`	⬆️
internal/errgroup/group.go	`93.93% <0.00%> (+1.51%)`	⬆️
internal/errors/errors.go	`37.50% <0.00%> (+1.56%)`	⬆️
internal/worker/queue.go	`100.00% <0.00%> (+5.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956e00c...4c15234. Read the comment docs.

github-actions · 2021-01-25T04:08:04Z

internal/errors/ngt_test.go

+}
+
+func TestErrInvalidDimensionSize(t *testing.T) {
+


🚫 [golangci] _{reported by reviewdog 🐶}
File is not gofumpt-ed (gofumpt)

internal/errors/ngt_test.go

github-actions · 2021-01-25T05:38:59Z

internal/errors/ngt.go

 	ErrDimensionLimitExceed = func(current, limit int) error {
 		return Errorf("supported dimension limit exceed:\trequired = %d,\tlimit = %d", current, limit)
 	}

+	// ErrIncompatibleDimensionSize represents a function to generate an error that the incompatible dimension size detected.


🚫 [golangci] _{reported by reviewdog 🐶}
line is 122 characters (lll)

vankichi

please check these suggestion

internal/errors/ngt.go

internal/errors/ngt_test.go

github-actions · 2021-01-27T11:35:58Z

internal/errors/ngt.go

 	ErrObjectNotFound = func(err error, uuid string) error {
 		return Wrapf(err, "ngt uuid %s's object not found", uuid)
 	}

+	// ErrRemoveRequestedBeforeIndexing represents a function to generate an error that the object is not indexed so can not remove it.


🚫 [golangci] _{reported by reviewdog 🐶}
line is 132 characters (lll)

github-actions · 2021-01-27T11:35:58Z

internal/errors/ngt_test.go

+				limit:   int(math.MinInt64),
+			},
+			want: want{
+				want: Errorf("dimension size %d is invalid, the supporting dimension size must be between 2 ~ %d", int(math.MinInt64), int(math.MinInt64)),


🚫 [golangci] _{reported by reviewdog 🐶}
line is 143 characters (lll)

github-actions · 2021-01-27T11:35:58Z

internal/errors/ngt_test.go

+				limit:   int(math.MaxInt64),
+			},
+			want: want{
+				want: Errorf("dimension size %d is invalid, the supporting dimension size must be between 2 ~ %d", int(math.MaxInt64), int(math.MaxInt64)),


🚫 [golangci] _{reported by reviewdog 🐶}
line is 143 characters (lll)

kevindiu

LGTM

kevindiu · 2021-02-01T09:33:55Z

/format
/rebase
/approve

vdaas-ci · 2021-02-01T09:34:35Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-ngt

vdaas-ci · 2021-02-01T09:35:56Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

kevindiu · 2021-02-01T09:44:58Z

/rebase
/format
/approve

vdaas-ci · 2021-02-01T09:46:41Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-ngt

vdaas-ci · 2021-02-01T09:50:44Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

kevindiu · 2021-02-01T09:51:07Z

/rebase
/format
/approve

github-actions · 2021-02-01T09:54:03Z

internal/errors/ngt_test.go

+				limit:   int(math.MinInt64),
+			},
+			want: want{
+				want: Errorf("supported dimension limit exceed:\trequired = %d,\tlimit = %d", int(math.MinInt64), int(math.MinInt64)),


🚫 [golangci] _{reported by reviewdog 🐶}
line is 122 characters (lll)

vdaas-ci · 2021-02-01T09:56:10Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-ngt

vdaas-ci · 2021-02-01T09:59:15Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

kevindiu · 2021-02-01T22:44:21Z

/rebase
/format
/approve

vdaas-ci · 2021-02-01T22:44:55Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-ngt

vdaas-ci · 2021-02-01T22:46:01Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

kevindiu · 2021-02-02T02:07:58Z

/rebase
/format
/approve

vdaas-ci · 2021-02-02T02:08:31Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-ngt

Signed-off-by: hlts2 <[email protected]>

Co-authored-by: Kiichiro YUKAWA <[email protected]>

Signed-off-by: vdaas-ci <[email protected]>

vdaas-ci · 2021-02-02T02:09:33Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

hlts2 self-assigned this Jan 20, 2021

github-actions bot added area/internal team/set SET team labels Jan 20, 2021

github-actions bot added size/S type/test Adding tests priority/low labels Jan 20, 2021

hlts2 commented Jan 20, 2021

View reviewed changes

internal/errors/ngt.go Outdated Show resolved Hide resolved

internal/errors/ngt.go Outdated Show resolved Hide resolved

hlts2 changed the title ~~Add test case for internal/errors/ngt.go~~ [WIP] Add test case for internal/errors/ngt.go Jan 20, 2021

github-actions bot added size/XXL and removed size/S labels Jan 25, 2021

github-actions bot reviewed Jan 25, 2021

View reviewed changes

hlts2 commented Jan 25, 2021

View reviewed changes

github-actions bot reviewed Jan 25, 2021

View reviewed changes

hlts2 requested a review from vankichi January 25, 2021 05:46

hlts2 marked this pull request as ready for review January 25, 2021 05:46

hlts2 changed the title ~~[WIP] Add test case for internal/errors/ngt.go~~ Add test case for internal/errors/ngt.go Jan 25, 2021

vankichi requested changes Jan 27, 2021

View reviewed changes

hlts2 commented Jan 27, 2021

View reviewed changes

internal/errors/ngt_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed Jan 27, 2021

View reviewed changes

vankichi previously approved these changes Jan 29, 2021

View reviewed changes

kevindiu previously approved these changes Feb 1, 2021

View reviewed changes

vdaas-ci dismissed stale reviews from kevindiu and vankichi via db2366f February 1, 2021 09:34

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-ngt branch from 6e53298 to db2366f Compare February 1, 2021 09:34

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-ngt branch from 7dd4e37 to b332e24 Compare February 1, 2021 09:46

github-actions bot reviewed Feb 1, 2021

View reviewed changes

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-ngt branch from b332e24 to 570383b Compare February 1, 2021 09:56

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-ngt branch from 8a58944 to 76d596b Compare February 1, 2021 22:45

hlts2 and others added 10 commits February 2, 2021 02:08

feat: add test file and comment

fbe2d8b

Signed-off-by: hlts2 <[email protected]>

Apply suggestions from code review

3f4a32b

feat: add test

3b3694b

Signed-off-by: hlts2 <[email protected]>

feat: add all test case for ngt errors

fea9104

Signed-off-by: hlts2 <[email protected]>

Apply suggestions from code review

8d5b22e

fix: forgetting to add test case

5b358d2

Signed-off-by: hlts2 <[email protected]>

Apply suggestions from code review

bc32be5

Co-authored-by: Kiichiro YUKAWA <[email protected]>

Apply suggestions from code review

e648ef8

Apply suggestions from code review

caa2235

🤖 Update license headers / Format go codes and yaml files

4c15234

Signed-off-by: vdaas-ci <[email protected]>

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-ngt branch from 76d596b to 4c15234 Compare February 2, 2021 02:08

kevindiu merged commit c5d78e1 into master Feb 2, 2021

kevindiu deleted the test/internal/add-newtest-for-errors-ngt branch February 2, 2021 02:12

vdaas-ci mentioned this pull request Feb 2, 2021

[major] v1.0.0 Release #974

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test case for internal/errors/ngt.go #936

Add test case for internal/errors/ngt.go #936

hlts2 commented Jan 20, 2021 •

edited

Loading

vdaas-ci commented Jan 20, 2021

codecov bot commented Jan 20, 2021 •

edited

Loading

github-actions bot Jan 25, 2021

github-actions bot Jan 25, 2021

vankichi left a comment

github-actions bot Jan 27, 2021

github-actions bot Jan 27, 2021

github-actions bot Jan 27, 2021

kevindiu left a comment

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

github-actions bot Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 2, 2021

vdaas-ci commented Feb 2, 2021

vdaas-ci commented Feb 2, 2021

Add test case for internal/errors/ngt.go #936

Add test case for internal/errors/ngt.go #936

Conversation

hlts2 commented Jan 20, 2021 • edited Loading

Description:

refactor

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Jan 20, 2021

codecov bot commented Jan 20, 2021 • edited Loading

Codecov Report

github-actions bot Jan 25, 2021

Choose a reason for hiding this comment

github-actions bot Jan 25, 2021

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

github-actions bot Jan 27, 2021

Choose a reason for hiding this comment

github-actions bot Jan 27, 2021

Choose a reason for hiding this comment

github-actions bot Jan 27, 2021

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

github-actions bot Feb 1, 2021

Choose a reason for hiding this comment

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 2, 2021

vdaas-ci commented Feb 2, 2021

vdaas-ci commented Feb 2, 2021

hlts2 commented Jan 20, 2021 •

edited

Loading

codecov bot commented Jan 20, 2021 •

edited

Loading