-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix add nil check for grpc connection pool objects in grpc/client.go #921
bugfix add nil check for grpc connection pool objects in grpc/client.go #921
Conversation
Signed-off-by: kpango <[email protected]>
[CHATOPS:HELP] ChatOps commands.
|
Signed-off-by: kpango <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #921 +/- ##
==========================================
- Coverage 16.23% 16.21% -0.02%
==========================================
Files 473 473
Lines 23174 23219 +45
==========================================
+ Hits 3763 3766 +3
- Misses 19169 19211 +42
Partials 242 242
Continue to review full report at Codecov.
|
Signed-off-by: kpango <[email protected]>
@@ -155,11 +156,15 @@ func (g *gRPCClient) StartConnectionMonitor(ctx context.Context) (<-chan error, | |||
prTick := &time.Ticker{ | |||
C: make(chan time.Time), | |||
} | |||
if g.enablePoolRebalance { | |||
reconnLimitDuration := time.Second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci] reported by reviewdog 🐶
ineffectual assignment to reconnLimitDuration
(ineffassign)
Signed-off-by: kpango <[email protected]>
Signed-off-by: kpango <[email protected]>
67b1692
to
8a99fc6
Compare
Signed-off-by: kpango [email protected]
Description:
add nill checking for grpc connection pool object
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: