-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove invalid import package from internal/errors/mysql_test.go #894
remove invalid import package from internal/errors/mysql_test.go #894
Conversation
Signed-off-by: vankichi <[email protected]>
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #894 +/- ##
==========================================
- Coverage 18.85% 18.81% -0.05%
==========================================
Files 423 422 -1
Lines 19600 19546 -54
==========================================
- Hits 3695 3677 -18
+ Misses 15687 15658 -29
+ Partials 218 211 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/fix-invalid-import-package-at-errors-mysql |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Signed-off-by: vankichi [email protected]
Description:
This PR will fix invalid import package in Vald.
internal/errors/mysql_test.go
importsgithub.com/pkg/errors
but we should not use this in Vald.I remove this pkg from import and fix a few test codes which is affected by removing.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: