Add test for internal/errors/compressor.go #870

hlts2 · 2020-12-07T04:41:27Z

Description:

I added test case for internal/errors/compressor.go.
And I refactored internal/errors/compressor.go.

WHY
Whenever Errorf has no arguments other than a message, nil is returned.
https://github.com/vdaas/vald/blob/master/internal/errors/compressor.go#L40
https://github.com/vdaas/vald/blob/master/internal/errors/compressor.go#L44
WHAT
Change from Errorf to New

grammar check passed

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2020-12-07T04:41:46Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

github-actions · 2020-12-07T04:46:42Z

internal/errors/compressor.go

 	ErrDecompressFailed = New("decompress failed")

+	// ErrCompressorRegistererIsNotRunning represents a function to generate an error of compressor registerers not running.


[golangci] _{reported by reviewdog 🐶}
line is 121 characters (lll)

github-actions · 2020-12-07T04:46:42Z

internal/errors/compressor.go

 	}

+	// ErrCompressorRegistererChannelIsFull represents a function to generate an error that compressor registerer channel is full.


[golangci] _{reported by reviewdog 🐶}
line is 127 characters (lll)

github-actions · 2020-12-07T04:46:42Z

internal/errors/compressor_test.go

@@ -0,0 +1,221 @@
+package errors


[golangci] _{reported by reviewdog 🐶}
package should be errors_test instead of errors (testpackage)

codecov · 2020-12-07T04:47:45Z

Codecov Report

Merging #870 (67d38f2) into master (8d62c74) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #870      +/-   ##
==========================================
+ Coverage   18.73%   18.84%   +0.11%     
==========================================
  Files         422      423       +1     
  Lines       19546    19600      +54     
==========================================
+ Hits         3662     3694      +32     
- Misses      15674    15688      +14     
- Partials      210      218       +8

Impacted Files	Coverage Δ
internal/errors/compressor.go	`100.00% <100.00%> (+100.00%)`	⬆️
internal/db/storage/blob/s3/reader/reader.go	`65.51% <0.00%> (-32.19%)`	⬇️
internal/worker/worker.go	`81.25% <0.00%> (-1.05%)`	⬇️
internal/net/net.go	`85.18% <0.00%> (ø)`
internal/errors/errors.go	`15.78% <0.00%> (+12.28%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43caa54...9aa3013. Read the comment docs.

kevindiu

LGTM

internal/errors/compressor.go

internal/errors/compressor_test.go

github-actions · 2020-12-16T05:40:54Z

internal/errors/compressor.go

 	ErrDecompressFailed = New("decompress failed")

+	// ErrCompressorRegistererIsNotRunning represents a function to generate an error of compressor registerers not running.


[golangci] _{reported by reviewdog 🐶}
line is 121 characters (lll)

github-actions · 2020-12-16T06:01:52Z

internal/errors/compressor.go

 	ErrDecompressFailed = New("decompress failed")

+	// ErrCompressorRegistererIsNotRunning represents a function to generate an error of compressor registerers is not running.


[golangci] _{reported by reviewdog 🐶}
line is 124 characters (lll)

kevindiu

LGTM

vankichi · 2020-12-18T01:43:02Z

/rebase
/format
/approve

vdaas-ci · 2020-12-18T01:43:39Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/errors-compressor

Signed-off-by: hlts2 <[email protected]>

Co-authored-by: Kiichiro YUKAWA <[email protected]>

Signed-off-by: hlts2 <[email protected]>

vdaas-ci · 2020-12-18T01:44:31Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Signed-off-by: vdaas-ci <[email protected]>

vdaas-ci

[APPROVED] This PR is approved by vankichi.

hlts2 self-assigned this Dec 7, 2020

github-actions bot added area/internal team/set SET team size/L type/test Adding tests priority/low labels Dec 7, 2020

github-actions bot reviewed Dec 7, 2020

View reviewed changes

hlts2 requested a review from kevindiu December 7, 2020 06:02

kevindiu previously approved these changes Dec 7, 2020

View reviewed changes

hlts2 requested a review from vankichi December 7, 2020 09:43

vankichi reviewed Dec 16, 2020

View reviewed changes

hlts2 dismissed kevindiu’s stale review via 63becdb December 16, 2020 05:35

github-actions bot reviewed Dec 16, 2020

View reviewed changes

kevindiu previously approved these changes Dec 17, 2020

View reviewed changes

hlts2 changed the title ~~Add test for internal/errors/compressor.go~~ Add test for internal/errors/compressor.go Dec 17, 2020

vankichi previously approved these changes Dec 18, 2020

View reviewed changes

hlts2 and others added 9 commits December 18, 2020 01:43

feat: add test case and comment

153e476

Signed-off-by: hlts2 <[email protected]>

fix: bug fix to generate error

16321f4

Signed-off-by: hlts2 <[email protected]>

fix: Errorf to New in test

5fc9571

Signed-off-by: hlts2 <[email protected]>

Update internal/errors/compressor.go

1b18d79

Co-authored-by: Kiichiro YUKAWA <[email protected]>

Update internal/errors/compressor.go

7238074

Co-authored-by: Kiichiro YUKAWA <[email protected]>

Update internal/errors/compressor.go

a90269a

Co-authored-by: Kiichiro YUKAWA <[email protected]>

fix: apply suggestion

d602bf2

Signed-off-by: hlts2 <[email protected]>

fix: test case name. value -> number

a9c4f8e

Signed-off-by: hlts2 <[email protected]>

fix: grammer

c057c09

Signed-off-by: hlts2 <[email protected]>

github-actions bot dismissed stale reviews from vankichi and kevindiu via c057c09 December 18, 2020 01:43

github-actions bot force-pushed the test/internal/errors-compressor branch from 67d38f2 to c057c09 Compare December 18, 2020 01:43

🤖 Update license headers / Format go codes and yaml files

9aa3013

Signed-off-by: vdaas-ci <[email protected]>

vdaas-ci approved these changes Dec 18, 2020

View reviewed changes

vankichi merged commit f8d5097 into master Dec 18, 2020

vankichi deleted the test/internal/errors-compressor branch December 18, 2020 03:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for internal/errors/compressor.go #870

Add test for internal/errors/compressor.go #870

hlts2 commented Dec 7, 2020 •

edited

Loading

vdaas-ci commented Dec 7, 2020

github-actions bot Dec 7, 2020

github-actions bot Dec 7, 2020

github-actions bot Dec 7, 2020

codecov bot commented Dec 7, 2020 •

edited

Loading

kevindiu left a comment

github-actions bot Dec 16, 2020

github-actions bot Dec 16, 2020

kevindiu left a comment

vankichi commented Dec 18, 2020

vdaas-ci commented Dec 18, 2020

vdaas-ci commented Dec 18, 2020

vdaas-ci left a comment

		ErrDecompressFailed = New("decompress failed")

		// ErrCompressorRegistererIsNotRunning represents a function to generate an error of compressor registerers not running.

		}

		// ErrCompressorRegistererChannelIsFull represents a function to generate an error that compressor registerer channel is full.

Add test for internal/errors/compressor.go #870

Add test for internal/errors/compressor.go #870

Conversation

hlts2 commented Dec 7, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Dec 7, 2020

github-actions bot Dec 7, 2020

Choose a reason for hiding this comment

github-actions bot Dec 7, 2020

Choose a reason for hiding this comment

github-actions bot Dec 7, 2020

Choose a reason for hiding this comment

codecov bot commented Dec 7, 2020 • edited Loading

Codecov Report

kevindiu left a comment

Choose a reason for hiding this comment

github-actions bot Dec 16, 2020

Choose a reason for hiding this comment

github-actions bot Dec 16, 2020

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

vankichi commented Dec 18, 2020

vdaas-ci commented Dec 18, 2020

vdaas-ci commented Dec 18, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

hlts2 commented Dec 7, 2020 •

edited

Loading

codecov bot commented Dec 7, 2020 •

edited

Loading