Add test case for json package #857

hlts2 · 2020-11-24T06:04:15Z

Signed-off-by: hlts2 [email protected]

Description:

This PR implements json pacakge test.

Related Ticket

https://github.com/vdaas/vald/projects/3#card-48143027

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

Signed-off-by: hlts2 <[email protected]>

vdaas-ci · 2020-11-24T06:04:41Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

codecov · 2020-11-24T06:18:17Z

Codecov Report

Merging #857 (4e61ee7) into master (b045e86) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #857      +/-   ##
==========================================
+ Coverage   18.22%   18.50%   +0.27%     
==========================================
  Files         421      421              
  Lines       19518    19518              
==========================================
+ Hits         3558     3611      +53     
+ Misses      15749    15700      -49     
+ Partials      211      207       -4

Impacted Files	Coverage Δ
internal/net/http/json/json.go	`80.00% <ø> (+31.25%)`	⬆️
internal/worker/worker.go	`83.33% <0.00%> (ø)`
internal/db/storage/blob/s3/reader/reader.go	`97.72% <0.00%> (+31.81%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 428740c...4e61ee7. Read the comment docs.

Signed-off-by: hlts2 <[email protected]>

internal/net/http/json/json_test.go

github-actions · 2020-11-26T03:16:52Z

internal/net/http/json/json_test.go

+					}
+
+					if len(gotHeaders) != 1 {
+						return errors.Errorf("header value length is wrong. key:%s want: %d, but got: %d", rest.ContentType, 1, len(gotHeaders))


[golangci] _{reported by reviewdog 🐶}
line is 126 characters (lll)

Signed-off-by: hlts2 <[email protected]>

internal/net/http/json/json_test.go

kevindiu · 2020-11-30T02:45:32Z

Please add missing comments in json.go
https://github.com/vdaas/vald/blob/test/internal/net-http-json/internal/net/http/json/json.go#L34

kevindiu

LGTM

Signed-off-by: hlts2 <[email protected]>

kevindiu

LGTM

vankichi · 2020-12-01T02:43:49Z

/rebase
/format
/approve

vdaas-ci · 2020-12-01T02:44:25Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/net-http-json

vdaas-ci · 2020-12-01T02:45:14Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

kevindiu

LGTM

Signed-off-by: hlts2 <[email protected]>

kevindiu

LGTM

vankichi

LGTM

vankichi · 2020-12-02T01:20:08Z

/rebase
/format
/approve

vdaas-ci · 2020-12-02T01:20:45Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/net-http-json

vdaas-ci · 2020-12-02T01:21:41Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

feat: add test case for json decode function

ac44d70

Signed-off-by: hlts2 <[email protected]>

hlts2 self-assigned this Nov 24, 2020

github-actions bot added area/internal team/set SET team size/L type/test Adding tests labels Nov 24, 2020

github-actions bot added the priority/low label Nov 24, 2020

hlts2 added 2 commits November 25, 2020 17:47

feat: add error case for decode data

3fa466e

Signed-off-by: hlts2 <[email protected]>

feat: add test case for encode & decode function

5621beb

Signed-off-by: hlts2 <[email protected]>

github-actions bot reviewed Nov 26, 2020

View reviewed changes

feat: test case for request

3b1a2b0

Signed-off-by: hlts2 <[email protected]>

hlts2 marked this pull request as ready for review November 30, 2020 00:53

hlts2 changed the title ~~[WIP] Add test case for json package~~ Add test case for json package Nov 30, 2020

fix: failing test for decoding

f25cbe7

Signed-off-by: hlts2 <[email protected]>

hlts2 requested a review from kevindiu November 30, 2020 02:27

fix: deleted new line

165086c

Signed-off-by: hlts2 <[email protected]>

github-actions bot reviewed Nov 30, 2020

View reviewed changes

internal/net/http/json/json_test.go Outdated Show resolved Hide resolved

internal/net/http/json/json_test.go Show resolved Hide resolved

kevindiu previously approved these changes Nov 30, 2020

View reviewed changes

fix: added comment for implementation

c803fcf

Signed-off-by: hlts2 <[email protected]>

hlts2 dismissed kevindiu’s stale review via c803fcf November 30, 2020 03:17

kevindiu approved these changes Nov 30, 2020

View reviewed changes

hlts2 requested a review from vankichi December 1, 2020 01:33

vankichi previously approved these changes Dec 1, 2020

View reviewed changes

vdaas-ci previously approved these changes Dec 1, 2020

View reviewed changes

kevindiu previously approved these changes Dec 1, 2020

View reviewed changes

fix: lint warning

4e61ee7

Signed-off-by: hlts2 <[email protected]>

hlts2 dismissed stale reviews from kevindiu, vdaas-ci, and vankichi via 4e61ee7 December 1, 2020 10:11

kevindiu approved these changes Dec 2, 2020

View reviewed changes

vankichi approved these changes Dec 2, 2020

View reviewed changes

vdaas-ci approved these changes Dec 2, 2020

View reviewed changes

vankichi merged commit aa681cf into master Dec 2, 2020

vankichi deleted the test/internal/net-http-json branch December 2, 2020 10:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test case for json package #857

Add test case for json package #857

hlts2 commented Nov 24, 2020 •

edited

Loading

vdaas-ci commented Nov 24, 2020

codecov bot commented Nov 24, 2020 •

edited

Loading

github-actions bot Nov 26, 2020

kevindiu commented Nov 30, 2020

kevindiu left a comment

kevindiu left a comment

vankichi commented Dec 1, 2020

vdaas-ci commented Dec 1, 2020

vdaas-ci commented Dec 1, 2020

vdaas-ci left a comment

kevindiu left a comment

kevindiu left a comment

vankichi left a comment

vankichi commented Dec 2, 2020

vdaas-ci commented Dec 2, 2020

vdaas-ci commented Dec 2, 2020

vdaas-ci left a comment

Add test case for json package #857

Add test case for json package #857

Conversation

hlts2 commented Nov 24, 2020 • edited Loading

Description:

Related Ticket

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Nov 24, 2020

codecov bot commented Nov 24, 2020 • edited Loading

Codecov Report

github-actions bot Nov 26, 2020

Choose a reason for hiding this comment

kevindiu commented Nov 30, 2020

kevindiu left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

vankichi commented Dec 1, 2020

vdaas-ci commented Dec 1, 2020

vdaas-ci commented Dec 1, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Dec 2, 2020

vdaas-ci commented Dec 2, 2020

vdaas-ci commented Dec 2, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

hlts2 commented Nov 24, 2020 •

edited

Loading

codecov bot commented Nov 24, 2020 •

edited

Loading